From c09c90c1a9e74ee4f29a051daf10bc4c5d5f7755 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Thu, 5 Mar 2015 20:27:58 -0500 Subject: tls_wrap: do not hold persistent ref to parent Hold non-persistent reference in JS, rather than in C++ to avoid cycles. PR-URL: https://github.com/iojs/io.js/pull/1078 Reviewed-By: Ben Noordhuis --- src/tls_wrap.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'src/tls_wrap.h') diff --git a/src/tls_wrap.h b/src/tls_wrap.h index 73a9f84ec0..9f095355bb 100644 --- a/src/tls_wrap.h +++ b/src/tls_wrap.h @@ -78,8 +78,7 @@ class TLSWrap : public crypto::SSLWrap, TLSWrap(Environment* env, Kind kind, StreamBase* stream, - v8::Handle stream_obj, - v8::Handle sc); + crypto::SecureContext* sc); static void SSLInfoCallback(const SSL* ssl_, int where, int ret); void InitSSL(); @@ -141,9 +140,7 @@ class TLSWrap : public crypto::SSLWrap, #endif // SSL_CTRL_SET_TLSEXT_SERVERNAME_CB crypto::SecureContext* sc_; - v8::Persistent sc_handle_; StreamBase* stream_; - v8::Persistent stream_handle_; BIO* enc_in_; BIO* enc_out_; NodeBIO* clear_in_; -- cgit v1.2.3