From 5026db142ab5d07c7144dfb272512d3388476a77 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 26 May 2019 22:34:51 +0200 Subject: src: use ArrayBufferViewContents more frequently MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using `ArrayBufferViewContents` over `Buffer::Data()`/`Buffer::Length()` or `SPREAD_BUFFER_ARG` has the advantages of creating fewer individual variables to keep track off, not being a “magic” macro that creates variables, reducing code size, and being faster when receiving on-heap TypedArrays. PR-URL: https://github.com/nodejs/node/pull/27920 Reviewed-By: Ben Noordhuis Reviewed-By: Sam Roberts Reviewed-By: Colin Ihrig --- src/tls_wrap.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/tls_wrap.cc') diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc index cde5419b9c..e9fe969358 100644 --- a/src/tls_wrap.cc +++ b/src/tls_wrap.cc @@ -187,9 +187,9 @@ void TLSWrap::Receive(const FunctionCallbackInfo& args) { TLSWrap* wrap; ASSIGN_OR_RETURN_UNWRAP(&wrap, args.Holder()); - CHECK(Buffer::HasInstance(args[0])); - char* data = Buffer::Data(args[0]); - size_t len = Buffer::Length(args[0]); + ArrayBufferViewContents buffer(args[0]); + const char* data = buffer.data(); + size_t len = buffer.length(); Debug(wrap, "Receiving %zu bytes injected from JS", len); // Copy given buffer entirely or partiall if handle becomes closed -- cgit v1.2.3