From 778f248914e1b498cd5d5e29006e346c62e8dcc6 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 10 May 2018 19:24:16 +0200 Subject: src: add missing override to ThreadPoolWork funcs Currently the following warnings are displayed when compiling: ../src/node_api.cc:3380:8: warning: 'AfterThreadPoolWork' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void AfterThreadPoolWork(int status) { ^ ../src/node_internals.h:513:16: note: overridden virtual function is here virtual void AfterThreadPoolWork(int status) = 0; ^ 1 warning generated. ../src/node_zlib.cc:220:8: warning: 'DoThreadPoolWork' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void DoThreadPoolWork() { ^ ../src/node_internals.h:512:16: note: overridden virtual function is here virtual void DoThreadPoolWork() = 0; ^ ../src/node_zlib.cc:224:8: warning: 'AfterThreadPoolWork' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void AfterThreadPoolWork(int status) { ^ ../src/node_internals.h:513:16: note: overridden virtual function is here virtual void AfterThreadPoolWork(int status) = 0; ^ 2 warnings generated. This commit adds override to the functions. PR-URL: https://github.com/nodejs/node/pull/20663 Reviewed-By: Anna Henningsen Reviewed-By: Michael Dawson --- src/node_zlib.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/node_zlib.cc') diff --git a/src/node_zlib.cc b/src/node_zlib.cc index c77e6d3297..ac5083862d 100644 --- a/src/node_zlib.cc +++ b/src/node_zlib.cc @@ -217,11 +217,11 @@ class ZCtx : public AsyncWrap, public ThreadPoolWork { // TODO(addaleax): Make these methods non-static. It's a significant bunch // of churn that's better left for a separate PR. - void DoThreadPoolWork() { + void DoThreadPoolWork() override { Process(this); } - void AfterThreadPoolWork(int status) { + void AfterThreadPoolWork(int status) override { After(this, status); } -- cgit v1.2.3