From 6072e01c938e22498cd46c3d8a2c21a16a632456 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 26 Oct 2019 18:29:46 +0200 Subject: src: do not use `std::function` for `OnScopeLeave` Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. PR-URL: https://github.com/nodejs/node/pull/30134 Reviewed-By: Gus Caplan Reviewed-By: Colin Ihrig Reviewed-By: David Carlier Reviewed-By: Franziska Hinkelmann Reviewed-By: James M Snell --- src/node_worker.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/node_worker.cc') diff --git a/src/node_worker.cc b/src/node_worker.cc index b35b4040ca..9f2da4c9de 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -242,7 +242,7 @@ void Worker::Run() { SealHandleScope outer_seal(isolate_); DeleteFnPtr env_; - OnScopeLeave cleanup_env([&]() { + auto cleanup_env = OnScopeLeave([&]() { if (!env_) return; env_->set_can_call_into_js(false); Isolate::DisallowJavascriptExecutionScope disallow_js(isolate_, -- cgit v1.2.3