From 45d0b4a300cbc845727fee75c59427cc343b1559 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Thu, 2 Aug 2018 01:07:57 +0200
Subject: src: yield empty maybes for failed AsyncWrap::MakeCallback calls

Use an empty `MaybeLocal<Value>` as the return value for
`AsyncWrap::MakeCallback()` if an exception occurred,
regardless of `MakeCallback` depth.

Unfortunately, the public API can not make this switch without
a breaking change (and possibly some kind of deprecation/renaming).

PR-URL: https://github.com/nodejs/node/pull/22078
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
---
 src/node_internals.h | 3 ---
 1 file changed, 3 deletions(-)

(limited to 'src/node_internals.h')

diff --git a/src/node_internals.h b/src/node_internals.h
index 0594d00580..968d229f10 100644
--- a/src/node_internals.h
+++ b/src/node_internals.h
@@ -543,9 +543,6 @@ class InternalCallbackScope {
 
   inline bool Failed() const { return failed_; }
   inline void MarkAsFailed() { failed_ = true; }
-  inline bool IsInnerMakeCallback() const {
-    return callback_scope_.in_makecallback();
-  }
 
  private:
   Environment* env_;
-- 
cgit v1.2.3