From 41637a530efb761c713a36f1465cc5ea9b976900 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 15 Aug 2019 15:03:43 +0200 Subject: http2: remove callback-based padding This option is not useful in practice, as mentioned in comments and the documentation, because the overhead of calling into JS makes it unreasonably expensive. PR-URL: https://github.com/nodejs/node/pull/29144 Reviewed-By: James M Snell Reviewed-By: Rich Trott --- src/node_http2_state.h | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'src/node_http2_state.h') diff --git a/src/node_http2_state.h b/src/node_http2_state.h index 692299a187..1ba3677f47 100644 --- a/src/node_http2_state.h +++ b/src/node_http2_state.h @@ -55,13 +55,6 @@ namespace http2 { IDX_OPTIONS_FLAGS }; - enum Http2PaddingBufferFields { - PADDING_BUF_FRAME_LENGTH, - PADDING_BUF_MAX_PAYLOAD_LENGTH, - PADDING_BUF_RETURN_VALUE, - PADDING_BUF_FIELD_COUNT - }; - enum Http2StreamStatisticsIndex { IDX_STREAM_STATS_ID, IDX_STREAM_STATS_TIMETOFIRSTBYTE, @@ -111,11 +104,6 @@ class Http2State { offsetof(http2_state_internal, session_stats_buffer), IDX_SESSION_STATS_COUNT, root_buffer), - padding_buffer( - isolate, - offsetof(http2_state_internal, padding_buffer), - PADDING_BUF_FIELD_COUNT, - root_buffer), options_buffer( isolate, offsetof(http2_state_internal, options_buffer), @@ -133,7 +121,6 @@ class Http2State { AliasedFloat64Array stream_state_buffer; AliasedFloat64Array stream_stats_buffer; AliasedFloat64Array session_stats_buffer; - AliasedUint32Array padding_buffer; AliasedUint32Array options_buffer; AliasedUint32Array settings_buffer; @@ -144,7 +131,6 @@ class Http2State { double stream_state_buffer[IDX_STREAM_STATE_COUNT]; double stream_stats_buffer[IDX_STREAM_STATS_COUNT]; double session_stats_buffer[IDX_SESSION_STATS_COUNT]; - uint32_t padding_buffer[PADDING_BUF_FIELD_COUNT]; uint32_t options_buffer[IDX_OPTIONS_FLAGS + 1]; uint32_t settings_buffer[IDX_SETTINGS_COUNT + 1]; }; -- cgit v1.2.3