From 51a50a09f0d01f7fa6fa3ee1f4b8f40504487d6c Mon Sep 17 00:00:00 2001 From: Jon Moss Date: Wed, 25 Jul 2018 21:15:10 -0400 Subject: src: use available ReqWrap instance for libuv req Use available `ReqWrap` descendant to make call to libuv -- avoid doing call with the `ReqWrap`'s request member and then calling `Dispatched()` afterwards. PR-URL: https://github.com/nodejs/node/pull/21980 Reviewed-By: Anna Henningsen Reviewed-By: Anatoli Papirovski Reviewed-By: Gus Caplan Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- src/node_file.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src/node_file.cc') diff --git a/src/node_file.cc b/src/node_file.cc index 8414a22ad4..17a44dd784 100644 --- a/src/node_file.cc +++ b/src/node_file.cc @@ -1552,9 +1552,12 @@ static void WriteString(const FunctionCallbackInfo& args) { len = StringBytes::Write(env->isolate(), *stack_buffer, len, args[1], enc); stack_buffer.SetLengthAndZeroTerminate(len); uv_buf_t uvbuf = uv_buf_init(*stack_buffer, len); - int err = uv_fs_write(env->event_loop(), req_wrap_async->req(), - fd, &uvbuf, 1, pos, AfterInteger); - req_wrap_async->Dispatched(); + int err = req_wrap_async->Dispatch(uv_fs_write, + fd, + &uvbuf, + 1, + pos, + AfterInteger); if (err < 0) { uv_fs_t* uv_req = req_wrap_async->req(); uv_req->result = err; -- cgit v1.2.3