From 3871cc5f0c791632d2555e159873530bfdd02d4f Mon Sep 17 00:00:00 2001 From: cjihrig Date: Tue, 19 Nov 2019 15:05:09 -0500 Subject: src: fix -Winconsistent-missing-override warning This commit addresses the following warning: ../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] v8::Maybe mark_arraybuffer_as_untransferable( ^ ../src/js_native_api_v8.h:42:27: note: overridden virtual function is here virtual v8::Maybe mark_arraybuffer_as_untransferable( PR-URL: https://github.com/nodejs/node/pull/30549 Reviewed-By: Anna Henningsen Reviewed-By: Ben Noordhuis Reviewed-By: Ruben Bridgewater Reviewed-By: Jiawen Geng Reviewed-By: David Carlier --- src/node_api.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/node_api.cc') diff --git a/src/node_api.cc b/src/node_api.cc index b293272b91..8df4559c6c 100644 --- a/src/node_api.cc +++ b/src/node_api.cc @@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ { } v8::Maybe mark_arraybuffer_as_untransferable( - v8::Local ab) const { + v8::Local ab) const override { return ab->SetPrivate( context(), node_env()->arraybuffer_untransferable_private_symbol(), -- cgit v1.2.3