From bd83c3966d4564709e8449b3c699af6ece27ff12 Mon Sep 17 00:00:00 2001 From: Trevor Norris Date: Tue, 9 Dec 2014 05:02:09 +0100 Subject: async-wrap: explicitly pass parent When instantiating a new AsyncWrap allow the parent AsyncWrap to be passed. This is useful for cases like TCP incoming connections, so the connection can be tied to the server receiving the connection. Because the current architecture instantiates the *Wrap inside a v8::FunctionCallback, the parent pointer is currently wrapped inside a new v8::External every time and passed as an argument. This adds ~80ns to instantiation time. A future optimization would be to add the v8::External as the data field when creating the v8::FunctionTemplate, change the pointer just before making the call then NULL'ing it out afterwards. This adds enough code complexity that it will not be attempted until the current approach demonstrates it is a bottle neck. PR-URL: https://github.com/joyent/node/pull/8110 Signed-off-by: Trevor Norris Reviewed-by: Fedor Indutny Reviewed-by: Alexis Campailla Reviewed-by: Julien Gilli --- src/handle_wrap.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/handle_wrap.h') diff --git a/src/handle_wrap.h b/src/handle_wrap.h index 13457e7cc5..8c5898e134 100644 --- a/src/handle_wrap.h +++ b/src/handle_wrap.h @@ -67,7 +67,8 @@ class HandleWrap : public AsyncWrap { HandleWrap(Environment* env, v8::Handle object, uv_handle_t* handle, - AsyncWrap::ProviderType provider); + AsyncWrap::ProviderType provider, + AsyncWrap* parent = nullptr); virtual ~HandleWrap() override; private: -- cgit v1.2.3