From 5877836a33c23dfa591f75005182fb4ab379bcdc Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 9 Nov 2018 12:25:22 +0800 Subject: src: remove pushValueToArray and SetupProcessObject The usage of NODE_PUSH_VAL_TO_ARRAY_MAX and push_values_to_array_function has all been removed in favor of the new Array::New API that takes a C++ array. Remove the unused code. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By: Anna Henningsen Reviewed-By: Daniel Bevenius Reviewed-By: Refael Ackermann --- src/env.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/env.h') diff --git a/src/env.h b/src/env.h index aec2f8fde4..01f686833e 100644 --- a/src/env.h +++ b/src/env.h @@ -82,10 +82,6 @@ struct PackageConfig { }; } // namespace loader -// The number of items passed to push_values_to_array_function has diminishing -// returns around 8. This should be used at all call sites using said function. -constexpr size_t NODE_PUSH_VAL_TO_ARRAY_MAX = 8; - // Stat fields buffers contain twice the number of entries in an uv_stat_t // because `fs.StatWatcher` needs room to store 2 `fs.Stats` instances. constexpr size_t kFsStatsFieldsNumber = 14; @@ -353,7 +349,6 @@ constexpr size_t kFsStatsBufferLength = kFsStatsFieldsNumber * 2; V(process_object, v8::Object) \ V(promise_handler_function, v8::Function) \ V(promise_wrap_template, v8::ObjectTemplate) \ - V(push_values_to_array_function, v8::Function) \ V(sab_lifetimepartner_constructor_template, v8::FunctionTemplate) \ V(script_context_constructor_template, v8::FunctionTemplate) \ V(script_data_constructor_function, v8::Function) \ -- cgit v1.2.3