From d4024815b7d55005c3ec25c74cf647f7eba1d5cc Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 21 Feb 2018 15:24:18 +0100 Subject: src: remove unnecessary Reset() calls The previous commit made persistent handles auto-reset on destruction. This commit removes the Reset() calls that are now no longer necessary. PR-URL: https://github.com/nodejs/node/pull/18656 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Joyee Cheung --- src/base_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/base_object.h') diff --git a/src/base_object.h b/src/base_object.h index 0640f91cbf..478499bbfe 100644 --- a/src/base_object.h +++ b/src/base_object.h @@ -34,7 +34,7 @@ class Environment; class BaseObject { public: inline BaseObject(Environment* env, v8::Local handle); - inline virtual ~BaseObject(); + virtual ~BaseObject() = default; // Returns the wrapped object. Returns an empty handle when // persistent.IsEmpty() is true. -- cgit v1.2.3