From 36793b8c650e80ad6f35728d586eda7637703466 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 7 May 2018 10:24:42 +0200 Subject: src: rename handle parameter object This commit renames the handle parameter for the BaseObject constructor to object instead of handle. The motivation for doing this is that when stepping through an inheritance chain it can sometimes be a little confusing when HandleWrap is in involved. HandleWrap has a handle parameter but calls the object that is passed to AsyncWrap object, but then when you end up in BaseObject it is named handle. PR-URL: https://github.com/nodejs/node/pull/20570 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- src/base_object-inl.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/base_object-inl.h') diff --git a/src/base_object-inl.h b/src/base_object-inl.h index 11ba1c88da..786e1f26b4 100644 --- a/src/base_object-inl.h +++ b/src/base_object-inl.h @@ -31,12 +31,12 @@ namespace node { -BaseObject::BaseObject(Environment* env, v8::Local handle) - : persistent_handle_(env->isolate(), handle), +BaseObject::BaseObject(Environment* env, v8::Local object) + : persistent_handle_(env->isolate(), object), env_(env) { - CHECK_EQ(false, handle.IsEmpty()); - CHECK_GT(handle->InternalFieldCount(), 0); - handle->SetAlignedPointerInInternalField(0, static_cast(this)); + CHECK_EQ(false, object.IsEmpty()); + CHECK_GT(object->InternalFieldCount(), 0); + object->SetAlignedPointerInInternalField(0, static_cast(this)); } -- cgit v1.2.3