From 1f3fbd43b7e73e16cb383bda36663517bf20540b Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 17 Apr 2018 17:47:09 +0200 Subject: src: remove `MarkIndependent()` calls MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The method has been deprecated in upstream V8, with messaging indicating that it is the default for handles to be independent now anyway. PR-URL: https://github.com/nodejs/node/pull/20108 Refs: https://github.com/v8/v8/commit/71ad48fb8f214e80518ba0419796e4c571351255 Reviewed-By: Anatoli Papirovski Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Matteo Collina --- src/base_object-inl.h | 1 - 1 file changed, 1 deletion(-) (limited to 'src/base_object-inl.h') diff --git a/src/base_object-inl.h b/src/base_object-inl.h index 51ef465996..5ff211f473 100644 --- a/src/base_object-inl.h +++ b/src/base_object-inl.h @@ -70,7 +70,6 @@ inline void BaseObject::MakeWeak(Type* ptr) { v8::Local handle = object(); CHECK_GT(handle->InternalFieldCount(), 0); Wrap(handle, ptr); - persistent_handle_.MarkIndependent(); persistent_handle_.SetWeak(ptr, WeakCallback, v8::WeakCallbackType::kParameter); } -- cgit v1.2.3