From bda7da34c6f8edabf45623acb21a410c76a33bff Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Mon, 20 May 2019 13:06:55 +0200 Subject: src: inline ProcessCliArgs in the Environment constructor Inline `ProcessCliArgs()` in the `Environment` constructor, and emit the `Environment` creation trace events with the arguments earlier. Remove the unused arguments passed to `CreateProcessObject()` since these are now attached to process in `PatchProcessObject()` during pre-execution instead. PR-URL: https://github.com/nodejs/node/pull/27539 Reviewed-By: Anna Henningsen --- src/api/environment.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/api') diff --git a/src/api/environment.cc b/src/api/environment.cc index eeeef7442d..5c3756c75d 100644 --- a/src/api/environment.cc +++ b/src/api/environment.cc @@ -281,11 +281,12 @@ Environment* CreateEnvironment(IsolateData* isolate_data, Environment* env = new Environment( isolate_data, context, + args, + exec_args, static_cast(Environment::kIsMainThread | Environment::kOwnsProcessState | Environment::kOwnsInspector)); env->InitializeLibuv(per_process::v8_is_profiling); - env->ProcessCliArgs(args, exec_args); if (RunBootstrapping(env).IsEmpty()) { return nullptr; } -- cgit v1.2.3