From ea44b8b283a7b056ebf194e4187e393bbd1ae651 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 13 Apr 2017 22:31:44 +0200 Subject: build: disable -O3 for C++ coverage The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: https://github.com/nodejs/node/pull/12406 Reviewed-By: Refael Ackermann Reviewed-By: Benjamin Gruenbaum Reviewed-By: Michael Dawson Reviewed-By: James M Snell --- node.gypi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'node.gypi') diff --git a/node.gypi b/node.gypi index ac05072bc8..a926d9a8e7 100644 --- a/node.gypi +++ b/node.gypi @@ -325,7 +325,8 @@ '-O0' ], 'cflags': [ '--coverage', '-g', - '-O0' ] + '-O0' ], + 'cflags!': [ '-O3' ] }], [ 'OS=="sunos"', { 'ldflags': [ '-Wl,-M,/usr/lib/ld/map.noexstk' ], -- cgit v1.2.3