From 6c205aba00d8a3ebad95eec60b0fcee46484cf4a Mon Sep 17 00:00:00 2001 From: Michaƫl Zasso Date: Wed, 9 Oct 2019 10:36:52 +0200 Subject: build: always use strings for compiler version in gyp files If GYP finds a string variable that can be converted to an integer, it will do it when the variable is expanded. Use "0.0" instead of "0" to force strings and be able to use comparison operations such as `gas_version >= "2.26"` in Python 3. PR-URL: https://github.com/nodejs/node/pull/29897 Reviewed-By: Christian Clauss Reviewed-By: Sam Roberts --- node.gyp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'node.gyp') diff --git a/node.gyp b/node.gyp index ced6fbc954..79969a4c83 100644 --- a/node.gyp +++ b/node.gyp @@ -290,7 +290,7 @@ '-Wl,-bnoerrmsg', ], }], - ['(OS=="linux" or OS=="mac") and llvm_version!=0', { + ['OS in ("linux", "mac") and llvm_version != "0.0"', { 'libraries': ['-latomic'], }], ], -- cgit v1.2.3