From 2bdeb88c27b4d8de3a8f6b7a438cf0bcb88fa927 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 22 Oct 2019 22:03:53 +0200 Subject: src: remove custom tracking for SharedArrayBuffers Remove custom tracking for `SharedArrayBuffer`s and their allocators and instead let V8 do the tracking of both. This is required starting in V8 7.9, because lifetime management for `ArrayBuffer::Allocator`s differs from what was performed previously (i.e. it is no longer easily possible for one Isolate to release an `ArrayBuffer` and another to accept it into its own allocator), and the alternative would have been adapting the `SharedArrayBuffer` tracking logic to also apply to regular `ArrayBuffer` instances. Refs: https://github.com/nodejs/node/pull/30044 PR-URL: https://github.com/nodejs/node/pull/30020 Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng Reviewed-By: Anna Henningsen Reviewed-By: Matteo Collina --- node.gyp | 2 -- 1 file changed, 2 deletions(-) (limited to 'node.gyp') diff --git a/node.gyp b/node.gyp index 6b70bc8363..d37be3141b 100644 --- a/node.gyp +++ b/node.gyp @@ -564,7 +564,6 @@ 'src/node_zlib.cc', 'src/pipe_wrap.cc', 'src/process_wrap.cc', - 'src/sharedarraybuffer_metadata.cc', 'src/signal_wrap.cc', 'src/spawn_sync.cc', 'src/stream_base.cc', @@ -642,7 +641,6 @@ 'src/pipe_wrap.h', 'src/req_wrap.h', 'src/req_wrap-inl.h', - 'src/sharedarraybuffer_metadata.h', 'src/spawn_sync.h', 'src/stream_base.h', 'src/stream_base-inl.h', -- cgit v1.2.3