From 6a689c8aa3ef3bf517cc86807406b9a8958d4ffb Mon Sep 17 00:00:00 2001 From: cjihrig Date: Thu, 23 Aug 2018 11:36:43 -0400 Subject: lib: make pipe_wrap binding internal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/22482 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: Luigi Pinca Reviewed-By: Michaƫl Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell --- lib/_tls_wrap.js | 2 +- lib/child_process.js | 3 ++- lib/internal/bootstrap/node.js | 1 + lib/internal/child_process.js | 2 +- lib/net.js | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js index 010973fddc..f806d70b99 100644 --- a/lib/_tls_wrap.js +++ b/lib/_tls_wrap.js @@ -35,7 +35,7 @@ const debug = util.debuglog('tls'); const { internalBinding } = require('internal/bootstrap/loaders'); const { TCP, constants: TCPConstants } = internalBinding('tcp_wrap'); const tls_wrap = internalBinding('tls_wrap'); -const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap'); +const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap'); const { owner_symbol } = require('internal/async_hooks').symbols; const { SecureContext: NativeSecureContext } = internalBinding('crypto'); const { diff --git a/lib/child_process.js b/lib/child_process.js index 1ab4150b01..05afcdbc6c 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -28,7 +28,8 @@ const { const { isArrayBufferView } = require('internal/util/types'); const debug = util.debuglog('child_process'); const { Buffer } = require('buffer'); -const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap'); +const { internalBinding } = require('internal/bootstrap/loaders'); +const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap'); const { ERR_INVALID_ARG_VALUE, ERR_CHILD_PROCESS_IPC_REQUIRED, diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index d65e12cc78..26d0b2710f 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -350,6 +350,7 @@ new SafeSet([ 'fs_event_wrap', 'uv', + 'pipe_wrap', 'http_parser', 'process_wrap', 'v8', diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js index 6c46aaf34d..70211e99fe 100644 --- a/lib/internal/child_process.js +++ b/lib/internal/child_process.js @@ -25,7 +25,7 @@ const { internalBinding } = require('internal/bootstrap/loaders'); const { Process } = internalBinding('process_wrap'); const { WriteWrap } = internalBinding('stream_wrap'); -const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap'); +const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap'); const { TCP } = internalBinding('tcp_wrap'); const { TTY } = internalBinding('tty_wrap'); const { UDP } = process.binding('udp_wrap'); diff --git a/lib/net.js b/lib/net.js index c489353b66..33c41c126e 100644 --- a/lib/net.js +++ b/lib/net.js @@ -53,7 +53,7 @@ const { Pipe, PipeConnectWrap, constants: PipeConstants -} = process.binding('pipe_wrap'); +} = internalBinding('pipe_wrap'); const { newAsyncId, defaultTriggerAsyncIdScope, -- cgit v1.2.3