From c7405fe9cb91124d966235467d6a9148e6bc9bd5 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 24 Sep 2018 11:15:37 +0200 Subject: Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE" This reverts commit 91eec00ca20a54b1dc010cfc2fb34bc2f39eab6b. Refs: https://github.com/nodejs/node/pull/21654 Refs: https://github.com/nodejs/node/issues/21203 PR-URL: https://github.com/nodejs/node/pull/23053 Reviewed-By: James M Snell --- lib/tty.js | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) (limited to 'lib/tty.js') diff --git a/lib/tty.js b/lib/tty.js index 83e00df110..62945a78eb 100644 --- a/lib/tty.js +++ b/lib/tty.js @@ -25,11 +25,7 @@ const { inherits, _extend } = require('util'); const net = require('net'); const { TTY, isTTY } = internalBinding('tty_wrap'); const errors = require('internal/errors'); -const { - ERR_INVALID_FD, - ERR_TTY_INIT_FAILED, - ERR_TTY_WRITABLE_NOT_READABLE -} = errors.codes; +const { ERR_INVALID_FD, ERR_TTY_INIT_FAILED } = errors.codes; const { getColorDepth } = require('internal/tty'); // Lazy loaded for startup performance. @@ -131,13 +127,6 @@ WriteStream.prototype._refreshSize = function() { } }; -// A WriteStream is not readable from, so _read become a no-op. -// this method could still be called because net.Socket() -// is a duplex -WriteStream.prototype._read = function() { - this.destroy(new ERR_TTY_WRITABLE_NOT_READABLE()); -}; - // Backwards-compat WriteStream.prototype.cursorTo = function(x, y) { if (readline === undefined) readline = require('readline'); -- cgit v1.2.3