From d022cb1bdd20f10483cbe988a950548df2dfd48c Mon Sep 17 00:00:00 2001 From: Weijia Wang <381152119@qq.com> Date: Wed, 13 Dec 2017 20:48:43 +0800 Subject: lib: combine similar error codes There two similar error codes in lib: "ERR_VALUE_OUT_OF_RANGE" and "ERR_OUT_OF_RANGE". This change is to reduce them into "ERR_VALUE_OUT_OF_RANGE" Fixes: https://github.com/nodejs/node/issues/17603 PR-URL: https://github.com/nodejs/node/pull/17648 Fixes: https://github.com/nodejs/node/issues/17603 Reviewed-By: Timothy Gu Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Jon Moss Reviewed-By: Anatoli Papirovski Reviewed-By: Anna Henningsen --- lib/events.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'lib/events.js') diff --git a/lib/events.js b/lib/events.js index 28a8c4228b..9ad5ec376f 100644 --- a/lib/events.js +++ b/lib/events.js @@ -56,7 +56,10 @@ Object.defineProperty(EventEmitter, 'defaultMaxListeners', { // greater and not a NaN). if (typeof arg !== 'number' || arg < 0 || arg !== arg) { const errors = lazyErrors(); - throw new errors.TypeError('ERR_OUT_OF_RANGE', 'defaultMaxListeners'); + throw new errors.RangeError('ERR_OUT_OF_RANGE', + 'defaultMaxListeners', + 'a non-negative number', + arg); } defaultMaxListeners = arg; } @@ -78,7 +81,8 @@ EventEmitter.init = function() { EventEmitter.prototype.setMaxListeners = function setMaxListeners(n) { if (typeof n !== 'number' || n < 0 || isNaN(n)) { const errors = lazyErrors(); - throw new errors.TypeError('ERR_OUT_OF_RANGE', 'n'); + throw new errors.RangeError('ERR_OUT_OF_RANGE', 'n', + 'a non-negative number', n); } this._maxListeners = n; return this; -- cgit v1.2.3