From e600fbe576e7806a01e11708b65830aeae96b590 Mon Sep 17 00:00:00 2001 From: Fedor Indutny Date: Thu, 4 May 2017 19:05:35 -0400 Subject: tls: accept `lookup` option for `tls.connect()` `net.connect()` and consequently `http.Agent` support custom DNS `lookup` option. However, as we move to `https.Agent` - this option no longer works because it is not proxied by `tls.connect`. Fix this inconsistency by passing it down to `net.connect`. PR-URL: https://github.com/nodejs/node/pull/12839 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Anna Henningsen Reviewed-By: Refael Ackermann Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Joyee Cheung Reviewed-By: Sam Roberts Reviewed-By: Ben Noordhuis --- lib/_tls_wrap.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lib/_tls_wrap.js') diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js index b8a962e734..23a5c2840e 100644 --- a/lib/_tls_wrap.js +++ b/lib/_tls_wrap.js @@ -1063,7 +1063,8 @@ exports.connect = function(...args /* [port,] [host,] [options,] [cb] */) { port: options.port, host: options.host, family: options.family, - localAddress: options.localAddress + localAddress: options.localAddress, + lookup: options.lookup }; } socket.connect(connect_opt, function() { -- cgit v1.2.3