From ce83099d3e6f6d7be0e533c19cd7f905bba4ea2a Mon Sep 17 00:00:00 2001 From: 陈刚 Date: Sun, 14 Jan 2018 23:34:18 +0800 Subject: stream: delete redundant code In `Writable.prototype.end()`, `state.ending` is true after calling `endWritable()` and it doesn't reset to false. In `Writable.prototype.uncork()`, `state.finished` must be false if `state.bufferedRequest` is true. PR-URL: https://github.com/nodejs/node/pull/18145 Reviewed-By: Ruben Bridgewater Reviewed-By: Matteo Collina --- lib/_stream_writable.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib/_stream_writable.js') diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js index 154c87bf5c..33c680cb5b 100644 --- a/lib/_stream_writable.js +++ b/lib/_stream_writable.js @@ -297,7 +297,6 @@ Writable.prototype.uncork = function() { if (!state.writing && !state.corked && - !state.finished && !state.bufferProcessing && state.bufferedRequest) clearBuffer(this, state); @@ -569,7 +568,7 @@ Writable.prototype.end = function(chunk, encoding, cb) { } // ignore unnecessary end() calls. - if (!state.ending && !state.finished) + if (!state.ending) endWritable(this, state, cb); }; -- cgit v1.2.3