From 3b2e9d26480da0c73a3735314bee5910cb3844ab Mon Sep 17 00:00:00 2001 From: isaacs Date: Thu, 21 Feb 2013 10:51:15 -0800 Subject: stream: remove lowWaterMark feature It seems like a good idea on the face of it, but lowWaterMarks are actually not useful, and in practice should always be set to zero. It would be worthwhile for writers if we actually did some kind of writev() type of thing, but actually this just delays calling write() and the overhead of doing a bunch of Buffer copies is not worth the slight benefit of calling write() fewer times. --- lib/_stream_transform.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'lib/_stream_transform.js') diff --git a/lib/_stream_transform.js b/lib/_stream_transform.js index 8b75a52b62..b83fedb626 100644 --- a/lib/_stream_transform.js +++ b/lib/_stream_transform.js @@ -60,9 +60,7 @@ // // However, even in such a pathological case, only a single written chunk // would be consumed, and then the rest would wait (un-transformed) until -// the results of the previous transformed chunk were consumed. Because -// the transform happens on-demand, it will only transform as much as is -// necessary to fill the readable buffer to the specified lowWaterMark. +// the results of the previous transformed chunk were consumed. module.exports = Transform; -- cgit v1.2.3