From 2e4ceb5747b0e5d1bccd79837de7731c4030dc48 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Wed, 17 Apr 2019 23:45:53 +0800 Subject: util: access process states lazily in debuglog `debuglog()` depends on `process.pid` and `process.env.NODE_DEBUG`, so it needs to be called lazily in top scopes of internal modules that may be loaded before these run time states are allowed to be accessed. This patch makes its implementation lazy by default, the process states are only accessed when the returned debug function is called for the first time. PR-URL: https://github.com/nodejs/node/pull/27281 Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Yongsheng Zhang --- lib/_stream_readable.js | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'lib/_stream_readable.js') diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 1b6f2175ce..34118f4fbe 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -30,14 +30,7 @@ const EE = require('events'); const Stream = require('stream'); const { Buffer } = require('buffer'); -let debuglog; -function debug(...args) { - if (!debuglog) { - debuglog = require('internal/util/debuglog').debuglog('stream'); - } - debuglog(...args); -} - +const debug = require('internal/util/debuglog').debuglog('stream'); const BufferList = require('internal/streams/buffer_list'); const destroyImpl = require('internal/streams/destroy'); const { getHighWaterMark } = require('internal/streams/state'); -- cgit v1.2.3