From ba565a37349e81c9d2402b0c8ef05ab39dca8968 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Mon, 1 Jul 2019 00:34:55 +0200
Subject: http: improve parser error messages
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Include the library-provided reason in the Error’s `message`.

Fixes: https://github.com/nodejs/node/issues/28468

PR-URL: https://github.com/nodejs/node/pull/28487
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
---
 lib/_http_server.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'lib/_http_server.js')

diff --git a/lib/_http_server.js b/lib/_http_server.js
index f82685e2be..941d571a67 100644
--- a/lib/_http_server.js
+++ b/lib/_http_server.js
@@ -35,7 +35,8 @@ const {
   httpSocketSetup,
   kIncomingMessage,
   HTTPParser,
-  _checkInvalidHeaderChar: checkInvalidHeaderChar
+  _checkInvalidHeaderChar: checkInvalidHeaderChar,
+  prepareError,
 } = require('_http_common');
 const { OutgoingMessage } = require('_http_outgoing');
 const { outHeadersKey, ondrain, nowDate } = require('internal/http');
@@ -550,6 +551,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
   resetSocketTimeout(server, socket, state);
 
   if (ret instanceof Error) {
+    prepareError(ret, parser, d);
     ret.rawPacket = d || parser.getCurrentBuffer();
     debug('parse error', ret);
     socketOnError.call(socket, ret);
-- 
cgit v1.2.3