From ba565a37349e81c9d2402b0c8ef05ab39dca8968 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Mon, 1 Jul 2019 00:34:55 +0200
Subject: http: improve parser error messages
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Include the library-provided reason in the Error’s `message`.

Fixes: https://github.com/nodejs/node/issues/28468

PR-URL: https://github.com/nodejs/node/pull/28487
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
---
 lib/_http_client.js | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'lib/_http_client.js')

diff --git a/lib/_http_client.js b/lib/_http_client.js
index 4af23fa8c5..a1750a1a00 100644
--- a/lib/_http_client.js
+++ b/lib/_http_client.js
@@ -33,6 +33,7 @@ const {
   httpSocketSetup,
   parsers,
   HTTPParser,
+  prepareError,
 } = require('_http_common');
 const { OutgoingMessage } = require('_http_outgoing');
 const Agent = require('_http_agent');
@@ -451,6 +452,7 @@ function socketOnData(d) {
 
   const ret = parser.execute(d);
   if (ret instanceof Error) {
+    prepareError(ret, parser, d);
     debug('parse error', ret);
     freeParser(parser, req, socket);
     socket.destroy();
-- 
cgit v1.2.3