From 810597d3353c85eb0aebdf16509a75e4f7dfb6e1 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Thu, 19 Apr 2018 15:02:31 +0300 Subject: doc: add hiding comments note to contributor guide PR-URL: https://github.com/nodejs/node/pull/20149 Reviewed-By: Ruben Bridgewater Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Ujjwal Sharma --- doc/guides/contributing/pull-requests.md | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'doc') diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 4d22004664..b6cc9eeeef 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -475,6 +475,10 @@ opportunity for the contributor to learn a bit more about the project. It is always good to clearly indicate nits when you comment: e.g. `Nit: change foo() to bar(). But this is not blocking.` +If your comments were addressed but were not folded automatically after new +commits or if they proved to be mistaken, please, [hide them][hiding-a-comment] +with the appropriate reason to keep the conversation flow concise and relevant. + ### Be aware of the person behind the code Be aware that *how* you communicate requests and reviews in your feedback can @@ -658,3 +662,4 @@ you can take a look at the [https://ci.nodejs.org/]: https://ci.nodejs.org/ [IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4 [Onboarding guide]: ../../onboarding.md +[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment -- cgit v1.2.3