From 77d3f141cf465613f0bcd270c6bd2bcd9c962f92 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 30 May 2018 14:23:32 +0200 Subject: doc: add notable-change to onboarding.md exercise Pull requests that add new Collaborators should be labeled `notable-change`. Make a note of this in onboarding.md. PR-URL: https://github.com/nodejs/node/pull/21040 Reviewed-By: Vse Mozhet Byt Reviewed-By: Trivikram Kamat Reviewed-By: Refael Ackermann Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- doc/onboarding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc') diff --git a/doc/onboarding.md b/doc/onboarding.md index 1474d24f1d..0748c1be7d 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -211,7 +211,7 @@ needs to be pointed out separately during the onboarding. -1` * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. -* Label your pull request with the `doc` subsystem label. +* Label your pull request with the `doc` and `notable-change` labels. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite` CI task. Alternatively, use the usual `node-test-pull-request` CI task and cancel it after the linter and one other -- cgit v1.2.3