From 5909532aace7412c5988bbfe2c777333aea2fd94 Mon Sep 17 00:00:00 2001 From: Thomas Watson Date: Thu, 10 Oct 2019 11:05:48 +0200 Subject: doc: use the WHATWG URL API in http code examples PR-URL: https://github.com/nodejs/node/pull/29917 Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat Reviewed-By: Luigi Pinca Reviewed-By: David Carlier --- doc/api/http.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'doc') diff --git a/doc/api/http.md b/doc/api/http.md index 0d98c91b93..351add59b5 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -353,7 +353,7 @@ A client and server pair demonstrating how to listen for the `'connect'` event: ```js const http = require('http'); const net = require('net'); -const url = require('url'); +const { URL } = require('url'); // Create an HTTP tunneling proxy const proxy = http.createServer((req, res) => { @@ -362,8 +362,8 @@ const proxy = http.createServer((req, res) => { }); proxy.on('connect', (req, cltSocket, head) => { // Connect to an origin server - const srvUrl = url.parse(`http://${req.url}`); - const srvSocket = net.connect(srvUrl.port, srvUrl.hostname, () => { + const { port, hostname } = new URL(`http://${req.url}`); + const srvSocket = net.connect(port || 80, hostname, () => { cltSocket.write('HTTP/1.1 200 Connection Established\r\n' + 'Proxy-agent: Node.js-Proxy\r\n' + '\r\n'); -- cgit v1.2.3