From 124a8e21238f8452028614625fe491b3049f7244 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 25 Sep 2018 06:35:33 -0700 Subject: doc: shorten pull request wait time to 48 hours MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, we have a 72 rule for how many hours a pull request should be left open at a minimum. Reduce that time to 48 hours. PR-URL: https://github.com/nodejs/node/pull/23082 Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Denys Otrishko Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina Reviewed-By: Franziska Hinkelmann Reviewed-By: Anatoli Papirovski --- doc/onboarding.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'doc') diff --git a/doc/onboarding.md b/doc/onboarding.md index bd9418fd91..ef7f328a31 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -138,7 +138,7 @@ onboarding session. * There is a minimum waiting time which we try to respect for non-trivial changes so that people who may have important input in such a distributed project are able to respond. - * For non-trivial changes, leave the pull request open for at least 72 hours. + * For non-trivial changes, leave the pull request open for at least 48 hours. * If a pull request is abandoned, check if they'd mind if you took it over (especially if it just has nits left). * Approving a change @@ -214,7 +214,7 @@ needs to be pointed out separately during the onboarding. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite-pipeline` CI task. * After one or two approvals, land the PR (PRs of this type do not need to wait - for 72 hours to land). + for 48 hours to land). * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing -- cgit v1.2.3