From 3cd7977a425d4ef6d2e9b6d535763bc5633789bf Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Tue, 23 Jan 2018 14:38:34 +0100 Subject: assert: use a default message in assert In case no arguments are passed to `assert.ok` it should just use a default message. Otherwise `assert.ok` can not be used as a callback. PR-URL: https://github.com/nodejs/node/pull/18319 Reviewed-By: James M Snell Reviewed-By: Weijia Wang Reviewed-By: Matteo Collina Reviewed-By: Joyee Cheung --- doc/api/assert.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'doc/api/assert.md') diff --git a/doc/api/assert.md b/doc/api/assert.md index 04f312aa66..09ea4483d1 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -692,9 +692,8 @@ parameter is an instance of an [`Error`][] then it will be thrown instead of the added: v0.1.21 changes: - version: REPLACEME - pr-url: https://github.com/nodejs/node/pull/17581 - description: assert.ok() will throw a `ERR_MISSING_ARGS` error. - Use assert.fail() instead. + pr-url: https://github.com/nodejs/node/pull/REPLACEME + description: assert.ok() (no arguments) will now use a predefined error msg. --> * `value` {any} * `message` {any} @@ -707,6 +706,8 @@ property set equal to the value of the `message` parameter. If the `message` parameter is `undefined`, a default error message is assigned. If the `message` parameter is an instance of an [`Error`][] then it will be thrown instead of the `AssertionError`. +If no arguments are passed in at all `message` will be set to the string: +"No value argument passed to assert.ok". Be aware that in the `repl` the error message will be different to the one thrown in a file! See below for further details. @@ -719,6 +720,10 @@ assert.ok(true); assert.ok(1); // OK +assert.ok(); +// throws: +// "AssertionError: No value argument passed to `assert.ok`. + assert.ok(false, 'it\'s false'); // throws "AssertionError: it's false" -- cgit v1.2.3