From 6f7e8b4521a52e16ab73f79225924179b4580ecd Mon Sep 17 00:00:00 2001 From: Benedikt Meurer Date: Wed, 15 May 2019 08:37:20 +0200 Subject: deps: V8: cherry-pick cca9ae3c9a MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: Remove recursion from NeedsCheckHeapObject. We use the predicate NeedsCheckHeapObject in the compiler frontend to determine whether we can skip introducing CheckHeapObject nodes. But this predicate would also walk up the graph in case of Phis, which can result in really long compilation times (on the main thread). In the report in https://github.com/nodejs/node/issues/27667, the compiler frontend alone took around 4-5mins of main thread time for a single function. With this patch the time goes down to 4-5ms. Bug: v8:9250 Refs: nodejs/node#27667 Change-Id: I231eb780ff04f949fa1669714f9af6ebfbcade05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612897 Reviewed-by: Jaroslav Sevcik Commit-Queue: Benedikt Meurer Cr-Commit-Position: refs/heads/master@{#61503} Fixes: https://github.com/nodejs/node/issues/27667 PR-URL: https://github.com/nodejs/node/pull/27729 Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: James M Snell --- deps/v8/src/compiler/property-access-builder.cc | 8 -------- 1 file changed, 8 deletions(-) (limited to 'deps') diff --git a/deps/v8/src/compiler/property-access-builder.cc b/deps/v8/src/compiler/property-access-builder.cc index 9f1d4d79cf..729f9e44ee 100644 --- a/deps/v8/src/compiler/property-access-builder.cc +++ b/deps/v8/src/compiler/property-access-builder.cc @@ -115,14 +115,6 @@ bool NeedsCheckHeapObject(Node* receiver) { case IrOpcode::kJSToString: case IrOpcode::kTypeOf: return false; - case IrOpcode::kPhi: { - Node* control = NodeProperties::GetControlInput(receiver); - if (control->opcode() != IrOpcode::kMerge) return true; - for (int i = 0; i < receiver->InputCount() - 1; ++i) { - if (NeedsCheckHeapObject(receiver->InputAt(i))) return true; - } - return false; - } default: return true; } -- cgit v1.2.3