From 70d1f32f5605465a1a630a64f6f0d35f96c7709d Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 19 Jun 2015 13:23:56 +0200 Subject: deps: update v8 to 4.4.63.9 Upgrade the bundled V8 and update code in src/ and lib/ to the new API. Notable backwards incompatible changes are the removal of the smalloc module and dropped support for CESU-8 decoding. CESU-8 support can be brought back if necessary by doing UTF-8 decoding ourselves. This commit includes https://codereview.chromium.org/1192973004 to fix a build error on python 2.6 systems. The original commit log follows: Use optparse in js2c.py for python compatibility Without this change, V8 won't build on RHEL/CentOS 6 because the distro python is too old to know about the argparse module. PR-URL: https://github.com/nodejs/io.js/pull/2022 Reviewed-By: Rod Vagg Reviewed-By: Trevor Norris --- deps/v8/samples/process.cc | 34 +++++++++++++++++++++++++++------- deps/v8/samples/shell.cc | 20 ++++++++++++-------- 2 files changed, 39 insertions(+), 15 deletions(-) (limited to 'deps/v8/samples') diff --git a/deps/v8/samples/process.cc b/deps/v8/samples/process.cc index f44797066b..8d1cebeab5 100644 --- a/deps/v8/samples/process.cc +++ b/deps/v8/samples/process.cc @@ -29,12 +29,26 @@ #include +#include +#include + #include #include using namespace std; using namespace v8; +class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator { + public: + virtual void* Allocate(size_t length) { + void* data = AllocateUninitialized(length); + return data == NULL ? data : memset(data, 0, length); + } + virtual void* AllocateUninitialized(size_t length) { return malloc(length); } + virtual void Free(void* data, size_t) { free(data); } +}; + + // These interfaces represent an existing request processing interface. // The idea is to imagine a real application that uses these interfaces // and then add scripting capabilities that allow you to interact with @@ -595,18 +609,21 @@ Handle ReadFile(Isolate* isolate, const string& name) { if (file == NULL) return Handle(); fseek(file, 0, SEEK_END); - int size = ftell(file); + size_t size = ftell(file); rewind(file); char* chars = new char[size + 1]; chars[size] = '\0'; - for (int i = 0; i < size;) { - int read = static_cast(fread(&chars[i], 1, size - i, file)); - i += read; + for (size_t i = 0; i < size;) { + i += fread(&chars[i], 1, size - i, file); + if (ferror(file)) { + fclose(file); + return Handle(); + } } fclose(file); - Handle result = - String::NewFromUtf8(isolate, chars, String::kNormalString, size); + Handle result = String::NewFromUtf8( + isolate, chars, String::kNormalString, static_cast(size)); delete[] chars; return result; } @@ -653,7 +670,10 @@ int main(int argc, char* argv[]) { fprintf(stderr, "No script was specified.\n"); return 1; } - Isolate* isolate = Isolate::New(); + ArrayBufferAllocator array_buffer_allocator; + Isolate::CreateParams create_params; + create_params.array_buffer_allocator = &array_buffer_allocator; + Isolate* isolate = Isolate::New(create_params); Isolate::Scope isolate_scope(isolate); HandleScope scope(isolate); Handle source = ReadFile(isolate, file); diff --git a/deps/v8/samples/shell.cc b/deps/v8/samples/shell.cc index 0ed742d3e3..48c042c795 100644 --- a/deps/v8/samples/shell.cc +++ b/deps/v8/samples/shell.cc @@ -82,8 +82,9 @@ int main(int argc, char* argv[]) { v8::V8::Initialize(); v8::V8::SetFlagsFromCommandLine(&argc, argv, true); ShellArrayBufferAllocator array_buffer_allocator; - v8::V8::SetArrayBufferAllocator(&array_buffer_allocator); - v8::Isolate* isolate = v8::Isolate::New(); + v8::Isolate::CreateParams create_params; + create_params.array_buffer_allocator = &array_buffer_allocator; + v8::Isolate* isolate = v8::Isolate::New(create_params); run_shell = (argc == 1); int result; { @@ -238,18 +239,21 @@ v8::Handle ReadFile(v8::Isolate* isolate, const char* name) { if (file == NULL) return v8::Handle(); fseek(file, 0, SEEK_END); - int size = ftell(file); + size_t size = ftell(file); rewind(file); char* chars = new char[size + 1]; chars[size] = '\0'; - for (int i = 0; i < size;) { - int read = static_cast(fread(&chars[i], 1, size - i, file)); - i += read; + for (size_t i = 0; i < size;) { + i += fread(&chars[i], 1, size - i, file); + if (ferror(file)) { + fclose(file); + return v8::Handle(); + } } fclose(file); - v8::Handle result = - v8::String::NewFromUtf8(isolate, chars, v8::String::kNormalString, size); + v8::Handle result = v8::String::NewFromUtf8( + isolate, chars, v8::String::kNormalString, static_cast(size)); delete[] chars; return result; } -- cgit v1.2.3