From 4c4af643e5042d615a60c6bbc05aee9d81b903e5 Mon Sep 17 00:00:00 2001 From: Michaël Zasso Date: Wed, 24 Jan 2018 20:16:06 +0100 Subject: deps: update V8 to 6.4.388.40 PR-URL: https://github.com/nodejs/node/pull/17489 Reviewed-By: Colin Ihrig Reviewed-By: Matteo Collina Reviewed-By: Myles Borins Reviewed-By: Ali Ijaz Sheikh --- deps/v8/infra/config/cq.cfg | 30 +++---- deps/v8/infra/mb/mb_config.pyl | 139 +++++++++++++++++---------------- deps/v8/infra/testing/OWNERS | 4 + deps/v8/infra/testing/README.md | 50 ++++++++++++ deps/v8/infra/testing/client.v8.pyl | 13 +++ deps/v8/infra/testing/tryserver.v8.pyl | 10 +++ 6 files changed, 162 insertions(+), 84 deletions(-) create mode 100644 deps/v8/infra/testing/OWNERS create mode 100644 deps/v8/infra/testing/README.md create mode 100644 deps/v8/infra/testing/client.v8.pyl create mode 100644 deps/v8/infra/testing/tryserver.v8.pyl (limited to 'deps/v8/infra') diff --git a/deps/v8/infra/config/cq.cfg b/deps/v8/infra/config/cq.cfg index dcf8e5c0b7..dbc20d5f80 100644 --- a/deps/v8/infra/config/cq.cfg +++ b/deps/v8/infra/config/cq.cfg @@ -9,16 +9,8 @@ commit_burst_delay: 60 max_commit_burst: 1 gerrit {} -rietveld { - url: "https://codereview.chromium.org" -} verifiers { - reviewer_lgtm { - committer_list: "project-v8-committers" - dry_run_access_list: "project-v8-tryjob-access" - } - gerrit_cq_ability { committer_list: "project-v8-committers" dry_run_access_list: "project-v8-tryjob-access" @@ -30,20 +22,26 @@ verifiers { try_job { buckets { - name: "master.tryserver.v8" + name: "luci.v8.try" builders { name: "v8_android_arm_compile_rel" } + builders { name: "v8_fuchsia_rel_ng" } + builders { name: "v8_linux64_gcc_compile_dbg" } + builders { name: "v8_linux_gcc_compile_rel" } + builders { name: "v8_linux_shared_compile_rel" } + builders { name: "v8_presubmit" } + builders { + name: "v8_win64_msvc_compile_rel" + experiment_percentage: 20 + } + } + buckets { + name: "master.tryserver.v8" builders { name: "v8_node_linux64_rel" } builders { name: "v8_linux64_asan_rel_ng" } builders { name: "v8_linux64_asan_rel_ng_triggered" triggered_by: "v8_linux64_asan_rel_ng" } - builders { name: "v8_linux64_avx2_rel_ng" } - builders { - name: "v8_linux64_avx2_rel_ng_triggered" - triggered_by: "v8_linux64_avx2_rel_ng" - } - builders { name: "v8_linux64_gcc_compile_dbg" } builders { name: "v8_linux64_gyp_rel_ng" } builders { name: "v8_linux64_gyp_rel_ng_triggered" @@ -75,7 +73,6 @@ verifiers { name: "v8_linux_dbg_ng_triggered" triggered_by: "v8_linux_dbg_ng" } - builders { name: "v8_linux_gcc_compile_rel" } builders { name: "v8_linux_mipsel_compile_rel" } builders { name: "v8_linux_mips64el_compile_rel" } builders { name: "v8_linux_nodcheck_rel_ng" } @@ -98,7 +95,6 @@ verifiers { name: "v8_mac_rel_ng_triggered" triggered_by: "v8_mac_rel_ng" } - builders { name: "v8_presubmit" } builders { name: "v8_win64_rel_ng" } builders { name: "v8_win64_rel_ng_triggered" diff --git a/deps/v8/infra/mb/mb_config.pyl b/deps/v8/infra/mb/mb_config.pyl index 3cbcddc073..afc7225148 100644 --- a/deps/v8/infra/mb/mb_config.pyl +++ b/deps/v8/infra/mb/mb_config.pyl @@ -62,9 +62,9 @@ 'V8 Linux - noi18n - debug': 'gn_debug_x86_no_i18n', 'V8 Linux - verify csa': 'gn_release_x86_verify_csa', # Linux64. - 'V8 Linux64 - builder': 'gn_release_x64_valgrind', + 'V8 Linux64 - builder': 'gn_release_x64', 'V8 Linux64 - concurrent marking - builder': 'gn_release_x64_concurrent_marking', - 'V8 Linux64 - debug builder': 'gn_debug_x64_valgrind', + 'V8 Linux64 - debug builder': 'gn_debug_x64', 'V8 Linux64 - custom snapshot - debug builder': 'gn_debug_x64_custom', 'V8 Linux64 - internal snapshot': 'gn_release_x64_internal', 'V8 Linux64 - gyp': 'gyp_release_x64', @@ -74,11 +74,10 @@ 'V8 Win32 - debug builder': 'gn_debug_x86_minimal_symbols', 'V8 Win32 - nosnap - shared': 'gn_release_x86_no_snap_shared_minimal_symbols', + 'V8 Win32 ASAN': 'gn_release_x86_asan_no_lsan', 'V8 Win64': 'gn_release_x64_minimal_symbols', 'V8 Win64 - debug': 'gn_debug_x64_minimal_symbols', - # TODO(machenbach): Switch plugins on when errors are fixed. - 'V8 Win64 - clang': 'gn_release_x64_clang', - 'V8 Win64 ASAN': 'gn_release_x64_asan_no_lsan', + 'V8 Win64 - msvc': 'gn_release_x64_msvc', # Mac. 'V8 Mac': 'gn_release_x86', 'V8 Mac - debug': 'gn_debug_x86', @@ -96,6 +95,8 @@ 'V8 Linux gcc 4.8': 'gn_release_x86_gcc', 'V8 Linux64 gcc 4.8 - debug': 'gn_debug_x64_gcc', # FYI. + 'V8 Fuchsia': 'gn_release_x64_fuchsia', + 'V8 Fuchsia - debug': 'gn_debug_x64_fuchsia', 'V8 Linux - swarming staging': 'gn_release_x64', 'V8 Linux64 - cfi': 'gn_release_x64_cfi', 'V8 Linux64 UBSanVptr': 'gn_release_x64_ubsan_vptr', @@ -107,6 +108,13 @@ 'V8 Random Deopt Fuzzer - debug': 'gn_debug_x64', }, 'client.v8.clusterfuzz': { + 'V8 Win32 ASAN - release builder': + 'gn_release_x86_asan_no_lsan_verify_heap', + # Note this is called a debug builder, but it uses a release build + # configuration with dchecks (which enables DEBUG in V8), since win-asan + # debug is not supported. + 'V8 Win32 ASAN - debug builder': + 'gn_release_x86_asan_no_lsan_verify_heap_dchecks', 'V8 Mac64 ASAN - release builder': 'gn_release_x64_asan_no_lsan_edge_verify_heap', 'V8 Mac64 ASAN - debug builder': @@ -127,7 +135,7 @@ 'gn_release_simulate_arm64_msan_no_origins_edge', 'V8 Linux MSAN chained origins': 'gn_release_simulate_arm64_msan_edge', - 'V8 Linux64 UBSan - release builder': 'gn_release_x64_ubsan_recover', + 'V8 Linux64 TSAN - release builder': 'gn_release_x64_tsan', 'V8 Linux64 UBSanVptr - release builder': 'gn_release_x64_ubsan_vptr_recover_edge', }, @@ -150,11 +158,11 @@ 'V8 Linux - mipsel - sim - builder': 'gn_release_simulate_mipsel', 'V8 Linux - mips64el - sim - builder': 'gn_release_simulate_mips64el', # PPC. - 'V8 Linux - ppc - sim': 'gyp_release_simulate_ppc', - 'V8 Linux - ppc64 - sim': 'gyp_release_simulate_ppc64', + 'V8 Linux - ppc - sim': 'gn_release_simulate_ppc', + 'V8 Linux - ppc64 - sim': 'gn_release_simulate_ppc64', # S390. - 'V8 Linux - s390 - sim': 'gyp_release_simulate_s390', - 'V8 Linux - s390x - sim': 'gyp_release_simulate_s390x', + 'V8 Linux - s390 - sim': 'gn_release_simulate_s390', + 'V8 Linux - s390x - sim': 'gn_release_simulate_s390x', }, 'client.v8.branches': { 'V8 Linux - beta branch': 'gn_release_x86', @@ -173,19 +181,19 @@ 'V8 mips64el - sim - stable branch': 'gn_release_simulate_mips64el', 'V8 mipsel - sim - beta branch': 'gn_release_simulate_mipsel', 'V8 mipsel - sim - stable branch': 'gn_release_simulate_mipsel', - 'V8 ppc - sim - beta branch': 'gyp_release_simulate_ppc', - 'V8 ppc - sim - stable branch': 'gyp_release_simulate_ppc', - 'V8 ppc64 - sim - beta branch': 'gyp_release_simulate_ppc64', - 'V8 ppc64 - sim - stable branch': 'gyp_release_simulate_ppc64', - 'V8 s390 - sim - beta branch': 'gyp_release_simulate_s390', - 'V8 s390 - sim - stable branch': 'gyp_release_simulate_s390', - 'V8 s390x - sim - beta branch': 'gyp_release_simulate_s390x', - 'V8 s390x - sim - stable branch': 'gyp_release_simulate_s390x', + 'V8 ppc - sim - beta branch': 'gn_release_simulate_ppc', + 'V8 ppc - sim - stable branch': 'gn_release_simulate_ppc', + 'V8 ppc64 - sim - beta branch': 'gn_release_simulate_ppc64', + 'V8 ppc64 - sim - stable branch': 'gn_release_simulate_ppc64', + 'V8 s390 - sim - beta branch': 'gn_release_simulate_s390', + 'V8 s390 - sim - stable branch': 'gn_release_simulate_s390', + 'V8 s390x - sim - beta branch': 'gn_release_simulate_s390x', + 'V8 s390x - sim - stable branch': 'gn_release_simulate_s390x', }, 'tryserver.v8': { + 'v8_fuchsia_rel_ng': 'gn_release_x64_fuchsia_trybot', 'v8_linux_rel_ng': 'gn_release_x86_gcmole_trybot', 'v8_linux_verify_csa_rel_ng': 'gn_release_x86_verify_csa', - 'v8_linux_avx2_dbg': 'gn_debug_x86_trybot', 'v8_linux_nodcheck_rel_ng': 'gn_release_x86_minimal_symbols', 'v8_linux_dbg_ng': 'gn_debug_x86_trybot', 'v8_linux_noi18n_rel_ng': 'gn_release_x86_no_i18n_trybot', @@ -194,12 +202,11 @@ 'v8_linux_nosnap_dbg': 'gn_debug_x86_no_snap_trybot', 'v8_linux_gcc_compile_rel': 'gn_release_x86_gcc_minimal_symbols', 'v8_linux_gcc_rel': 'gn_release_x86_gcc_minimal_symbols', + 'v8_linux_shared_compile_rel': 'gn_release_x86_shared_verify_heap', 'v8_linux64_gcc_compile_dbg': 'gn_debug_x64_gcc', - 'v8_linux64_rel_ng': 'gn_release_x64_valgrind_trybot', + 'v8_linux64_rel_ng': 'gn_release_x64_trybot', 'v8_linux64_verify_csa_rel_ng': 'gn_release_x64_verify_csa', 'v8_linux64_gyp_rel_ng': 'gyp_release_x64', - 'v8_linux64_avx2_rel_ng': 'gn_release_x64_trybot', - 'v8_linux64_avx2_dbg': 'gn_debug_x64_trybot', 'v8_linux64_asan_rel_ng': 'gn_release_x64_asan_minimal_symbols', 'v8_linux64_msan_rel': 'gn_release_simulate_arm64_msan_minimal_symbols', 'v8_linux64_sanitizer_coverage_rel': @@ -208,12 +215,14 @@ 'v8_linux64_tsan_concurrent_marking_rel_ng': 'gn_release_x64_tsan_concurrent_marking_minimal_symbols', 'v8_linux64_ubsan_rel_ng': 'gn_release_x64_ubsan_vptr_minimal_symbols', + 'v8_win_asan_rel_ng': 'gn_release_x86_asan_no_lsan', 'v8_win_dbg': 'gn_debug_x86_trybot', 'v8_win_compile_dbg': 'gn_debug_x86_trybot', 'v8_win_rel_ng': 'gn_release_x86_trybot', 'v8_win_nosnap_shared_rel_ng': 'gn_release_x86_no_snap_shared_minimal_symbols', - 'v8_win64_asan_rel_ng': 'gn_release_x64_asan_no_lsan', + # TODO(machenbach): Rename bot to msvc. + 'v8_win64_msvc_compile_rel': 'gn_release_x64_msvc', 'v8_win64_dbg': 'gn_debug_x64_minimal_symbols', 'v8_win64_rel_ng': 'gn_release_x64_trybot', 'v8_mac_rel_ng': 'gn_release_x86_trybot', @@ -355,11 +364,18 @@ 'gn', 'release_bot', 'simulate_mipsel', 'swarming'], 'gn_release_simulate_mips64el': [ 'gn', 'release_bot', 'simulate_mips64el', 'swarming'], + 'gn_release_simulate_ppc': [ + 'gn', 'release_bot', 'simulate_ppc', 'swarming'], + 'gn_release_simulate_ppc64': [ + 'gn', 'release_bot', 'simulate_ppc64', 'swarming'], + 'gn_release_simulate_s390': [ + 'gn', 'release_bot', 'simulate_s390', 'swarming'], + 'gn_release_simulate_s390x': [ + 'gn', 'release_bot', 'simulate_s390x', 'swarming'], # GN debug configs for arm. 'gn_debug_arm': [ - 'gn', 'debug_bot', 'arm', 'crosscompile', 'hard_float', 'swarming', - 'no_custom_libcxx'], + 'gn', 'debug_bot', 'arm', 'crosscompile', 'hard_float', 'swarming'], # GN release configs for arm. 'gn_release_arm': [ @@ -394,12 +410,16 @@ 'gn', 'release_bot', 'x64', 'cfi', 'swarming'], 'gn_release_x64_cfi_clusterfuzz': [ 'gn', 'release_bot', 'x64', 'cfi_clusterfuzz'], - 'gn_release_x64_clang': [ - 'gn', 'release_bot', 'x64', 'clang', 'swarming'], + 'gn_release_x64_msvc': [ + 'gn', 'release_bot', 'x64', 'msvc', 'swarming'], 'gn_release_x64_concurrent_marking': [ 'gn', 'release_bot', 'x64', 'v8_enable_concurrent_marking', 'swarming'], 'gn_release_x64_correctness_fuzzer' : [ - 'gn', 'release_bot', 'x64', 'v8_correctness_fuzzer'], + 'gn', 'release_bot', 'x64', 'v8_correctness_fuzzer', 'swarming'], + 'gn_release_x64_fuchsia': [ + 'gn', 'release_bot', 'x64', 'fuchsia', 'swarming'], + 'gn_release_x64_fuchsia_trybot': [ + 'gn', 'release_trybot', 'x64', 'fuchsia', 'swarming'], 'gn_release_x64_gcc_coverage': [ 'gn', 'release_bot', 'x64', 'coverage', 'gcc'], 'gn_release_x64_internal': [ @@ -418,20 +438,12 @@ 'minimal_symbols', 'swarming'], 'gn_release_x64_tsan_minimal_symbols': [ 'gn', 'release_bot', 'x64', 'tsan', 'minimal_symbols', 'swarming'], - 'gn_release_x64_ubsan_recover': [ - 'gn', 'release_bot', 'x64', 'ubsan_recover', 'swarming'], 'gn_release_x64_ubsan_vptr': [ 'gn', 'release_bot', 'x64', 'ubsan_vptr', 'swarming'], 'gn_release_x64_ubsan_vptr_recover_edge': [ 'gn', 'release_bot', 'x64', 'edge', 'ubsan_vptr_recover', 'swarming'], 'gn_release_x64_ubsan_vptr_minimal_symbols': [ 'gn', 'release_bot', 'x64', 'ubsan_vptr', 'minimal_symbols', 'swarming'], - 'gn_release_x64_valgrind': [ - 'gn', 'release_bot', 'x64', 'swarming', 'valgrind', - 'no_custom_libcxx'], - 'gn_release_x64_valgrind_trybot': [ - 'gn', 'release_trybot', 'x64', 'swarming', 'valgrind', - 'no_custom_libcxx'], 'gn_release_x64_verify_csa': [ 'gn', 'release_bot', 'x64', 'swarming', 'dcheck_always_on', 'v8_enable_slow_dchecks', 'v8_verify_csa'], @@ -446,15 +458,12 @@ 'v8_optimized_debug', 'x64', 'asan', 'edge', 'swarming'], 'gn_debug_x64_custom': [ 'gn', 'debug_bot', 'x64', 'swarming', 'v8_snapshot_custom'], + 'gn_debug_x64_fuchsia': [ + 'gn', 'debug_bot', 'x64', 'fuchsia', 'swarming'], 'gn_debug_x64_gcc': [ 'gn', 'debug_bot', 'x64', 'gcc'], 'gn_debug_x64_minimal_symbols': [ 'gn', 'debug_bot', 'x64', 'minimal_symbols', 'swarming'], - 'gn_debug_x64_trybot': [ - 'gn', 'debug_trybot', 'x64', 'swarming'], - 'gn_debug_x64_valgrind': [ - 'gn', 'debug_bot', 'x64', 'swarming', 'valgrind', - 'no_custom_libcxx'], # GN debug configs for x86. 'gn_debug_x86': [ @@ -478,6 +487,14 @@ # GN release configs for x86. 'gn_release_x86': [ 'gn', 'release_bot', 'x86', 'swarming'], + 'gn_release_x86_asan_no_lsan': [ + 'gn', 'release_bot', 'x86', 'asan', 'clang', 'swarming'], + 'gn_release_x86_asan_no_lsan_verify_heap': [ + 'gn', 'release_bot', 'x86', 'asan', 'clang', 'swarming', + 'v8_verify_heap'], + 'gn_release_x86_asan_no_lsan_verify_heap_dchecks': [ + 'gn', 'release_bot', 'x86', 'asan', 'clang', 'swarming', + 'dcheck_always_on', 'v8_enable_slow_dchecks', 'v8_verify_heap'], 'gn_release_x86_disassembler': [ 'gn', 'release_bot', 'x86', 'v8_enable_disassembler'], 'gn_release_x86_gcc': [ @@ -513,22 +530,12 @@ # Gyp release configs for mips. 'gyp_release_mips_no_snap_no_i18n': [ - 'gyp', 'release', 'mips', 'crosscompile', 'static', 'v8_no_i18n', - 'v8_snapshot_none'], - - # Gyp release configs for simulators. - 'gyp_release_simulate_ppc': [ - 'gyp', 'release_bot', 'simulate_ppc', 'swarming'], - 'gyp_release_simulate_ppc64': [ - 'gyp', 'release_bot', 'simulate_ppc64', 'swarming'], - 'gyp_release_simulate_s390': [ - 'gyp', 'release_bot', 'simulate_s390', 'swarming'], - 'gyp_release_simulate_s390x': [ - 'gyp', 'release_bot', 'simulate_s390x', 'swarming'], + 'gyp', 'release', 'mips', 'crosscompile', 'no_sysroot', 'static', + 'v8_no_i18n', 'v8_snapshot_none'], # Gyp release configs for x64. 'gyp_release_x64': [ - 'gyp', 'release_bot', 'x64', 'swarming'], + 'gyp', 'release_bot', 'x64', 'no_sysroot', 'swarming'], }, 'mixins': { @@ -608,6 +615,10 @@ 'gyp_defines': 'sanitizer_coverage=trace-pc-guard', }, + 'fuchsia': { + 'gn_args': 'target_os="fuchsia"', + }, + 'gcc': { # TODO(machenbach): Remove cxx11 restriction when updating gcc version. 'gn_args': 'is_clang=false use_cxx11=true', @@ -660,9 +671,13 @@ 'use_prebuilt_instrumented_libraries=true'), }, - # TODO(machenbach): Remove when http://crbug.com/738814 is resolved. - 'no_custom_libcxx': { - 'gn_args': 'use_custom_libcxx=false', + 'msvc': { + 'gn_args': 'is_clang=false', + }, + + 'no_sysroot': { + 'gn_args': 'use_sysroot=false', + 'gyp_defines': 'use_sysroot=0', }, 'release': { @@ -745,11 +760,6 @@ 'gyp_defines': 'clang=1 tsan=1', }, - 'ubsan_recover': { - # Ubsan with recovery. - 'gn_args': 'is_ubsan=true is_ubsan_no_recover=false', - }, - 'ubsan_vptr': { # TODO(krasin): Remove is_ubsan_no_recover=true when # https://llvm.org/bugs/show_bug.cgi?id=25569 is fixed and just use @@ -762,11 +772,6 @@ 'gn_args': 'is_ubsan_vptr=true is_ubsan_no_recover=false', }, - 'valgrind': { - 'gn_args': 'v8_has_valgrind=true', - 'gyp_defines': 'has_valgrind=1', - }, - 'v8_no_i18n': { 'gn_args': 'v8_enable_i18n_support=false icu_use_data_file=false', 'gyp_defines': 'v8_enable_i18n_support=0 icu_use_data_file_flag=0', diff --git a/deps/v8/infra/testing/OWNERS b/deps/v8/infra/testing/OWNERS new file mode 100644 index 0000000000..f0129f758e --- /dev/null +++ b/deps/v8/infra/testing/OWNERS @@ -0,0 +1,4 @@ +set noparent + +machenbach@chromium.org +sergiyb@chromium.org \ No newline at end of file diff --git a/deps/v8/infra/testing/README.md b/deps/v8/infra/testing/README.md new file mode 100644 index 0000000000..3099062477 --- /dev/null +++ b/deps/v8/infra/testing/README.md @@ -0,0 +1,50 @@ +# Src-side test specifications + +The infra/testing folder in V8 contains test specifications, consumed and +executed by the continuous infrastructure. Every master has an optional file +named `.pyl`. E.g. `tryserver.v8.pyl`. + +The structure of each file is: +``` +{ + : [ + { + 'name': , + 'variant': , + 'shards': , + }, + ... + ], + ... +} +``` +The `` is a string name of the builder to execute the tests. +`` is a label defining a test specification matching the +[infra-side](https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/v8/testing.py#58). +The `` is a testing variant as specified in +`v8/tools/testrunner/local/variants.py`. `` is optional +(default 1), but can be provided to increase the swarming shards for +long-running tests. + +Example: +``` +{ + 'v8_linux64_rel_ng_triggered': [ + {'name': 'v8testing', 'variant': 'nooptimization', 'shards': 2}, + ], +} +``` + +## Guidelines + +Please keep trybots and continuous bots in sync. E.g. add the same configuration +for the release and debug CI bots and the corresponding trybot (where +applicable). E.g. + +``` +tryserver.v8: + v8_linux64_rel_ng_triggered +client.v8: + V8 Linux64 + V8 Linux64 - debug +``` \ No newline at end of file diff --git a/deps/v8/infra/testing/client.v8.pyl b/deps/v8/infra/testing/client.v8.pyl new file mode 100644 index 0000000000..80d75a920a --- /dev/null +++ b/deps/v8/infra/testing/client.v8.pyl @@ -0,0 +1,13 @@ +# Copyright 2017 The V8 project authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +{ + ### Example configuration for CI bots (please keep as reference). + # 'V8 Linux64': [ + # {'name': 'benchmarks', 'variant': 'default', 'shards': 1}, + # ], + # 'V8 Linux64 - debug': [ + # {'name': 'benchmarks', 'variant': 'default', 'shards': 1}, + # ], +} \ No newline at end of file diff --git a/deps/v8/infra/testing/tryserver.v8.pyl b/deps/v8/infra/testing/tryserver.v8.pyl new file mode 100644 index 0000000000..f296779c4e --- /dev/null +++ b/deps/v8/infra/testing/tryserver.v8.pyl @@ -0,0 +1,10 @@ +# Copyright 2017 The V8 project authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +{ + ### Example configuration for trybots (please keep as reference). + # 'v8_linux64_rel_ng_triggered': [ + # {'name': 'benchmarks', 'variant': 'default', 'shards': 1}, + # ], +} \ No newline at end of file -- cgit v1.2.3