From 22aa3d48997f1fc31e9c9cc08ec76a5436c93fe3 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Mon, 17 Apr 2017 04:01:12 +0300 Subject: benchmark: reduce string concatenations PR-URL: https://github.com/nodejs/node/pull/12455 Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell --- benchmark/path/basename-posix.js | 2 +- benchmark/path/basename-win32.js | 2 +- benchmark/path/dirname-posix.js | 2 +- benchmark/path/dirname-win32.js | 2 +- benchmark/path/extname-posix.js | 2 +- benchmark/path/extname-win32.js | 2 +- benchmark/path/format-posix.js | 2 +- benchmark/path/format-win32.js | 2 +- benchmark/path/isAbsolute-posix.js | 2 +- benchmark/path/isAbsolute-win32.js | 2 +- benchmark/path/join-posix.js | 2 +- benchmark/path/join-win32.js | 2 +- benchmark/path/makeLong-win32.js | 2 +- benchmark/path/normalize-posix.js | 2 +- benchmark/path/normalize-win32.js | 2 +- benchmark/path/parse-posix.js | 2 +- benchmark/path/parse-win32.js | 2 +- benchmark/path/relative-posix.js | 2 +- benchmark/path/relative-win32.js | 2 +- benchmark/path/resolve-posix.js | 2 +- benchmark/path/resolve-win32.js | 2 +- 21 files changed, 21 insertions(+), 21 deletions(-) (limited to 'benchmark/path') diff --git a/benchmark/path/basename-posix.js b/benchmark/path/basename-posix.js index fc983c8074..10465b2c73 100644 --- a/benchmark/path/basename-posix.js +++ b/benchmark/path/basename-posix.js @@ -21,7 +21,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var input = '' + conf.pathext; + var input = String(conf.pathext); var ext; var extIdx = input.indexOf('|'); if (extIdx !== -1) { diff --git a/benchmark/path/basename-win32.js b/benchmark/path/basename-win32.js index b493beb87c..77bf326ed2 100644 --- a/benchmark/path/basename-win32.js +++ b/benchmark/path/basename-win32.js @@ -21,7 +21,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var input = '' + conf.pathext; + var input = String(conf.pathext); var ext; var extIdx = input.indexOf('|'); if (extIdx !== -1) { diff --git a/benchmark/path/dirname-posix.js b/benchmark/path/dirname-posix.js index af77be5ac0..a72aceb89e 100644 --- a/benchmark/path/dirname-posix.js +++ b/benchmark/path/dirname-posix.js @@ -18,7 +18,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/dirname-win32.js b/benchmark/path/dirname-win32.js index 01d97d08e2..11a89073e6 100644 --- a/benchmark/path/dirname-win32.js +++ b/benchmark/path/dirname-win32.js @@ -18,7 +18,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/extname-posix.js b/benchmark/path/extname-posix.js index 50c4e8f792..25d53d08e1 100644 --- a/benchmark/path/extname-posix.js +++ b/benchmark/path/extname-posix.js @@ -21,7 +21,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/extname-win32.js b/benchmark/path/extname-win32.js index 9c0df13ab4..d4a4638a68 100644 --- a/benchmark/path/extname-win32.js +++ b/benchmark/path/extname-win32.js @@ -21,7 +21,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/format-posix.js b/benchmark/path/format-posix.js index ee78a6d5f3..04f6207775 100644 --- a/benchmark/path/format-posix.js +++ b/benchmark/path/format-posix.js @@ -12,7 +12,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var props = ('' + conf.props).split('|'); + var props = String(conf.props).split('|'); var obj = { root: props[0] || '', dir: props[1] || '', diff --git a/benchmark/path/format-win32.js b/benchmark/path/format-win32.js index 9ec981d631..189fe9c34f 100644 --- a/benchmark/path/format-win32.js +++ b/benchmark/path/format-win32.js @@ -12,7 +12,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var props = ('' + conf.props).split('|'); + var props = String(conf.props).split('|'); var obj = { root: props[0] || '', dir: props[1] || '', diff --git a/benchmark/path/isAbsolute-posix.js b/benchmark/path/isAbsolute-posix.js index 22db751100..cff0474654 100644 --- a/benchmark/path/isAbsolute-posix.js +++ b/benchmark/path/isAbsolute-posix.js @@ -16,7 +16,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/isAbsolute-win32.js b/benchmark/path/isAbsolute-win32.js index a565da8e56..0eeeb64531 100644 --- a/benchmark/path/isAbsolute-win32.js +++ b/benchmark/path/isAbsolute-win32.js @@ -17,7 +17,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/join-posix.js b/benchmark/path/join-posix.js index a7cf377252..326789bf39 100644 --- a/benchmark/path/join-posix.js +++ b/benchmark/path/join-posix.js @@ -12,7 +12,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var args = ('' + conf.paths).split('|'); + var args = String(conf.paths).split('|'); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/join-win32.js b/benchmark/path/join-win32.js index 18c1e802a6..5042d270e1 100644 --- a/benchmark/path/join-win32.js +++ b/benchmark/path/join-win32.js @@ -12,7 +12,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var args = ('' + conf.paths).split('|'); + var args = String(conf.paths).split('|'); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/makeLong-win32.js b/benchmark/path/makeLong-win32.js index fe5da425a5..0cc6c66204 100644 --- a/benchmark/path/makeLong-win32.js +++ b/benchmark/path/makeLong-win32.js @@ -15,7 +15,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/normalize-posix.js b/benchmark/path/normalize-posix.js index aec703cbe2..541f7b9112 100644 --- a/benchmark/path/normalize-posix.js +++ b/benchmark/path/normalize-posix.js @@ -17,7 +17,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/normalize-win32.js b/benchmark/path/normalize-win32.js index 356d399c35..3af2aca434 100644 --- a/benchmark/path/normalize-win32.js +++ b/benchmark/path/normalize-win32.js @@ -17,7 +17,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var input = '' + conf.path; + var input = String(conf.path); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/parse-posix.js b/benchmark/path/parse-posix.js index 997eec0452..0130c16aa5 100644 --- a/benchmark/path/parse-posix.js +++ b/benchmark/path/parse-posix.js @@ -18,7 +18,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var input = '' + conf.path; + var input = String(conf.path); for (var i = 0; i < n; i++) { p.parse(input); diff --git a/benchmark/path/parse-win32.js b/benchmark/path/parse-win32.js index 2a95f75866..fbcff5fd68 100644 --- a/benchmark/path/parse-win32.js +++ b/benchmark/path/parse-win32.js @@ -19,7 +19,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var input = '' + conf.path; + var input = String(conf.path); for (var i = 0; i < n; i++) { p.parse(input); diff --git a/benchmark/path/relative-posix.js b/benchmark/path/relative-posix.js index 492b73c3e8..3fb6dc9ee1 100644 --- a/benchmark/path/relative-posix.js +++ b/benchmark/path/relative-posix.js @@ -18,7 +18,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var from = '' + conf.paths; + var from = String(conf.paths); var to = ''; var delimIdx = from.indexOf('|'); if (delimIdx > -1) { diff --git a/benchmark/path/relative-win32.js b/benchmark/path/relative-win32.js index 7e7620299e..fafda6d1ce 100644 --- a/benchmark/path/relative-win32.js +++ b/benchmark/path/relative-win32.js @@ -16,7 +16,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var from = '' + conf.paths; + var from = String(conf.paths); var to = ''; var delimIdx = from.indexOf('|'); if (delimIdx > -1) { diff --git a/benchmark/path/resolve-posix.js b/benchmark/path/resolve-posix.js index d1364a8ac2..61b809b666 100644 --- a/benchmark/path/resolve-posix.js +++ b/benchmark/path/resolve-posix.js @@ -15,7 +15,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.posix; - var args = ('' + conf.paths).split('|'); + var args = String(conf.paths).split('|'); bench.start(); for (var i = 0; i < n; i++) { diff --git a/benchmark/path/resolve-win32.js b/benchmark/path/resolve-win32.js index 6dfb38167c..ccfeec696d 100644 --- a/benchmark/path/resolve-win32.js +++ b/benchmark/path/resolve-win32.js @@ -15,7 +15,7 @@ var bench = common.createBenchmark(main, { function main(conf) { var n = +conf.n; var p = path.win32; - var args = ('' + conf.paths).split('|'); + var args = String(conf.paths).split('|'); bench.start(); for (var i = 0; i < n; i++) { -- cgit v1.2.3