From 6a5ab5d550719f416683ec0d588461b8bc9a8787 Mon Sep 17 00:00:00 2001 From: Brian White Date: Sat, 11 Mar 2017 19:41:20 -0500 Subject: fs: include more fs.stat*() optimizations Including: * Move async *stat() functions to FillStatsArray() now used by the sync *stat() functions * Avoid creating fs.Stats instances for implicit async/sync *stat() calls used in various fs functions * Store reference to Float64Array data on C++ side for easier/faster access, instead of passing from JS to C++ on every async/sync *stat() call PR-URL: https://github.com/nodejs/node/pull/11665 Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell Reviewed-By: Anna Henningsen Reviewed-By: Matteo Collina Reviewed-By: Colin Ihrig --- benchmark/fs/bench-statSync.js | 37 ++++++++++++------------------------- 1 file changed, 12 insertions(+), 25 deletions(-) (limited to 'benchmark/fs/bench-statSync.js') diff --git a/benchmark/fs/bench-statSync.js b/benchmark/fs/bench-statSync.js index 4bc2ecd65a..57e03df3b0 100644 --- a/benchmark/fs/bench-statSync.js +++ b/benchmark/fs/bench-statSync.js @@ -4,36 +4,23 @@ const common = require('../common'); const fs = require('fs'); const bench = common.createBenchmark(main, { - n: [1e4], + n: [1e6], kind: ['fstatSync', 'lstatSync', 'statSync'] }); function main(conf) { const n = conf.n >>> 0; - var fn; - var i; - switch (conf.kind) { - case 'statSync': - case 'lstatSync': - fn = fs[conf.kind]; - bench.start(); - for (i = 0; i < n; i++) { - fn(__filename); - } - bench.end(n); - break; - case 'fstatSync': - fn = fs.fstatSync; - const fd = fs.openSync(__filename, 'r'); - bench.start(); - for (i = 0; i < n; i++) { - fn(fd); - } - bench.end(n); - fs.closeSync(fd); - break; - default: - throw new Error('Invalid kind argument'); + const kind = conf.kind; + const arg = (kind === 'fstatSync' ? fs.openSync(__filename, 'r') : __dirname); + const fn = fs[conf.kind]; + + bench.start(); + for (var i = 0; i < n; i++) { + fn(arg); } + bench.end(n); + + if (kind === 'fstat') + fs.closeSync(arg); } -- cgit v1.2.3