From 8ae32a98642fdb1cf9187c67fe0050129f6a5216 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 4 Jun 2014 15:25:09 +0200 Subject: bench: fix buffers/buffer-base64-encode benchmark The test is supposed to measure the performance of the base64 encoder so move the Buffer#write() calls out of the benchmark section. The overhead of the calls isn't terrible (about 1-3%) but having unrelated activity in a micro-benchmark is never a good idea. Signed-off-by: Trevor Norris --- benchmark/buffers/buffer-base64-encode.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'benchmark/buffers/buffer-base64-encode.js') diff --git a/benchmark/buffers/buffer-base64-encode.js b/benchmark/buffers/buffer-base64-encode.js index f2b8e9a482..3dcc13b6b6 100644 --- a/benchmark/buffers/buffer-base64-encode.js +++ b/benchmark/buffers/buffer-base64-encode.js @@ -28,9 +28,8 @@ function main(conf) { var b = Buffer(N); var s = ''; for (var i = 0; i < 256; ++i) s += String.fromCharCode(i); - - bench.start(); for (var i = 0; i < N; i += 256) b.write(s, i, 256, 'ascii'); + bench.start(); for (var i = 0; i < 32; ++i) b.toString('base64'); bench.end(64); } -- cgit v1.2.3