From f265225c19ddd9b63472d5ddcdc9f6ff8edae866 Mon Sep 17 00:00:00 2001 From: Tom Gallacher Date: Fri, 18 Jan 2019 16:30:10 +0000 Subject: src: allow --perf-prof-unwinding-info in NODE_OPTIONS PR-URL: https://github.com/nodejs/node/pull/25565 Reviewed-By: Sam Roberts Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: Gireesh Punathil Reviewed-By: James M Snell --- doc/api/cli.md | 1 + src/node_options.cc | 4 ++++ test/parallel/test-cli-node-options.js | 1 + 3 files changed, 6 insertions(+) diff --git a/doc/api/cli.md b/doc/api/cli.md index 734e80d558..5e817eaa1d 100644 --- a/doc/api/cli.md +++ b/doc/api/cli.md @@ -730,6 +730,7 @@ V8 options that are allowed are: - `--perf-basic-prof` - `--perf-basic-prof-only-functions` - `--perf-prof` +- `--perf-prof-unwinding-info` - `--stack-trace-limit` ### `NODE_PATH=path[:…]` diff --git a/src/node_options.cc b/src/node_options.cc index 7b678e549a..e68487a2bf 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -322,6 +322,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() { V8Option{}, kAllowedInEnvironment); AddOption("--perf-prof", "", V8Option{}, kAllowedInEnvironment); + AddOption("--perf-prof-unwinding-info", + "", + V8Option{}, + kAllowedInEnvironment); AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment); #ifdef NODE_REPORT diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js index 1554e80c0b..8f65a8cb7e 100644 --- a/test/parallel/test-cli-node-options.js +++ b/test/parallel/test-cli-node-options.js @@ -44,6 +44,7 @@ if (!common.isWindows) { if (common.isLinux && ['arm', 'x64'].includes(process.arch)) { // PerfJitLogger is only implemented in Linux. expect('--perf-prof', 'B\n'); + expect('--perf-prof-unwinding-info', 'B\n'); } if (common.hasCrypto) { -- cgit v1.2.3