From d37789deeb5e951500d7fb499602dc100d3212fb Mon Sep 17 00:00:00 2001 From: Ali Ijaz Sheikh Date: Wed, 8 Nov 2017 22:08:13 -0800 Subject: src: perf_hooks: fix wrong sized delete Depending on the allocator, existing code leaks memory. PR-URL: https://github.com/nodejs/node/pull/16898 Reviewed-By: Franziska Hinkelmann Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Khaidi Chu --- src/node_perf.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/node_perf.cc b/src/node_perf.cc index a27a1b3dd7..94c3a0f8e0 100644 --- a/src/node_perf.cc +++ b/src/node_perf.cc @@ -196,7 +196,9 @@ void PerformanceGCCallback(uv_async_t* handle) { cleanup: delete data; - auto closeCB = [](uv_handle_t* handle) { delete handle; }; + auto closeCB = [](uv_handle_t* handle) { + delete reinterpret_cast(handle); + }; uv_close(reinterpret_cast(handle), closeCB); } -- cgit v1.2.3