From 7d18e922ab093c9c85b365dbc7fd01984316abc3 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 25 Nov 2018 20:04:53 -0800 Subject: doc: revise accepting-modifications in guide MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: https://github.com/nodejs/node/pull/24650 Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Franziska Hinkelmann Reviewed-By: Richard Lau --- COLLABORATOR_GUIDE.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 90d52105a7..8673713564 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -93,12 +93,10 @@ to land but is [author ready](#author-ready-pull-requests), add the ## Accepting Modifications -All modifications to the Node.js code and documentation should be performed via -GitHub pull requests, including modifications by Collaborators and TSC members. -A pull request must be reviewed, and must also be tested with CI, before being -landed into the codebase. There may be exceptions to the latter (the changed -code cannot be tested with a CI or similar). If that is the case, please leave a -comment that explains why the PR does not require a CI run. +Contributors propose modifications to Node.js using GitHub pull requests. This +is true for all modifications including those proposed by TSC members and other +Collaborators. A pull request must pass code review and CI before landing into +the codebase. ### Code Reviews -- cgit v1.2.3