From 2825e1183d87354507e2e847f0891116d48b1a38 Mon Sep 17 00:00:00 2001 From: Guy Bedford Date: Thu, 26 Sep 2019 23:21:52 -0400 Subject: module: move cjs type check behind flag MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/29732 Reviewed-By: Michaƫl Zasso Reviewed-By: David Carlier Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: Jan Krems Reviewed-By: Gus Caplan Reviewed-By: James M Snell Reviewed-By: Anto Aravinth --- lib/internal/modules/cjs/loader.js | 2 +- test/es-module/test-esm-type-flag-errors.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js index 8ef01b4499..341163ef8c 100644 --- a/lib/internal/modules/cjs/loader.js +++ b/lib/internal/modules/cjs/loader.js @@ -953,7 +953,7 @@ Module.prototype._compile = function(content, filename) { // Native extension for .js Module._extensions['.js'] = function(module, filename) { - if (filename.endsWith('.js')) { + if (experimentalModules && filename.endsWith('.js')) { const pkg = readPackageScope(filename); if (pkg && pkg.type === 'module') { throw new ERR_REQUIRE_ESM(filename); diff --git a/test/es-module/test-esm-type-flag-errors.js b/test/es-module/test-esm-type-flag-errors.js index a54a018ad9..8725fb6232 100644 --- a/test/es-module/test-esm-type-flag-errors.js +++ b/test/es-module/test-esm-type-flag-errors.js @@ -1,3 +1,4 @@ +// Flags: --experimental-modules 'use strict'; const common = require('../common'); const assert = require('assert'); -- cgit v1.2.3