From 27f6d04dcf092c23d00d19eacf13e5c751ea9c5f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 14 Jan 2019 14:20:07 -0800 Subject: test: improve known_issues/test-vm-timeout-escape-queuemicrotask Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: https://github.com/nodejs/node/pull/25503 Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen Reviewed-By: Ben Coe --- test/known_issues/test-vm-timeout-escape-queuemicrotask.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/known_issues/test-vm-timeout-escape-queuemicrotask.js b/test/known_issues/test-vm-timeout-escape-queuemicrotask.js index 1ed327f779..df0531bae1 100644 --- a/test/known_issues/test-vm-timeout-escape-queuemicrotask.js +++ b/test/known_issues/test-vm-timeout-escape-queuemicrotask.js @@ -12,14 +12,17 @@ const NS_PER_MS = 1000000n; const hrtime = process.hrtime.bigint; +const loopDuration = common.platformTimeout(100n); +const timeout = common.platformTimeout(10); + function loop() { const start = hrtime(); while (1) { const current = hrtime(); const span = (current - start) / NS_PER_MS; - if (span >= 100n) { + if (span >= loopDuration) { throw new Error( - `escaped timeout at ${span} milliseconds!`); + `escaped ${timeout}ms timeout at ${span}ms`); } } } @@ -32,9 +35,9 @@ assert.throws(() => { queueMicrotask, loop }, - { timeout: common.platformTimeout(5) } + { timeout } ); }, { code: 'ERR_SCRIPT_EXECUTION_TIMEOUT', - message: 'Script execution timed out after 5ms' + message: `Script execution timed out after ${timeout}ms` }); -- cgit v1.2.3