From 25ade76fb01258d8a789a9cd893b284542827efd Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 23 May 2017 08:28:13 +0200 Subject: test: add override to ServerDone function Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void ServerDone() { ^ ../src/inspector_socket_server.h:30:16: note: overridden virtual function is here virtual void ServerDone() = 0; ^ This commit marks ServerDone with override to get rid of the warning. PR-URL: https://github.com/nodejs/node/pull/13166 Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Refael Ackermann --- test/cctest/test_inspector_socket_server.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 356ef41070..4e292691c1 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -139,7 +139,7 @@ class TestInspectorServerDelegate : public SocketServerDelegate { server_->Send(session_id_, message); } - void ServerDone() { + void ServerDone() override { done = true; } -- cgit v1.2.3