diff options
| author | Bartosz Sosnowski <bartosz@janeasystems.com> | 2017-11-13 16:59:11 +0100 |
|---|---|---|
| committer | Bartosz Sosnowski <bartosz@janeasystems.com> | 2018-02-22 12:43:35 +0100 |
| commit | 887a2ba92eec98ddf1e0953e742419236eff75d7 (patch) | |
| tree | 948c1e772a5583d4081dbd28d43708f2ccaef36a /vcbuild.bat | |
| parent | d3955d15ff5c68acf91f35177d290ff068068a05 (diff) | |
| download | android-node-v8-887a2ba92eec98ddf1e0953e742419236eff75d7.tar.gz android-node-v8-887a2ba92eec98ddf1e0953e742419236eff75d7.tar.bz2 android-node-v8-887a2ba92eec98ddf1e0953e742419236eff75d7.zip | |
build, win: vcbuild improvements
Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message when no VS2017 installation is found.
Adds support for DEBUG_HELPER to vcbuild.bat.
Fixes: https://github.com/nodejs/node/issues/16864
PR-URL: https://github.com/nodejs/node/pull/17015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'vcbuild.bat')
| -rw-r--r-- | vcbuild.bat | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/vcbuild.bat b/vcbuild.bat index 88693a71cb..a664492831 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -1,4 +1,4 @@ -@echo off +@if not defined DEBUG_HELPER @ECHO OFF cd %~dp0 @@ -166,7 +166,7 @@ if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu :no-depsicu call tools\msvs\find_python.cmd -if errorlevel 1 echo Could not find python2 & goto :exit +if errorlevel 1 goto :exit call :getnodeversion || exit /b 1 |