diff options
| author | Yihong Wang <yh.wang@ibm.com> | 2018-07-24 13:44:09 -0700 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-09-17 17:31:40 +0200 |
| commit | 29cf335e6a81343d910910fb17d68743cc2bb5c3 (patch) | |
| tree | 24a9a69e4f354a346c6f8d98f3ee916c7ff0a723 /vcbuild.bat | |
| parent | 4286dcf17f062034117043a2640b620210b61f57 (diff) | |
| download | android-node-v8-29cf335e6a81343d910910fb17d68743cc2bb5c3.tar.gz android-node-v8-29cf335e6a81343d910910fb17d68743cc2bb5c3.tar.bz2 android-node-v8-29cf335e6a81343d910910fb17d68743cc2bb5c3.zip | |
build: skip cctest on Windows shared lib build
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/21228
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'vcbuild.bat')
| -rw-r--r-- | vcbuild.bat | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/vcbuild.bat b/vcbuild.bat index e237cf9ee5..0c7bd0f48b 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -529,6 +529,7 @@ if "%test_args%"=="" goto test-v8 if "%config%"=="Debug" set test_args=--mode=debug %test_args% if "%config%"=="Release" set test_args=--mode=release %test_args% if defined no_cctest echo Skipping cctest because no-cctest was specified && goto run-test-py +if not exist %config%\cctest.exe goto run-test-py echo running 'cctest %cctest_args%' "%config%\cctest" %cctest_args% :run-test-py |