summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2019-01-23 12:01:01 +0100
committerDaniel Bevenius <daniel.bevenius@gmail.com>2019-02-01 14:08:20 +0100
commitf4510c4148b50b47ac22fdb5331ce726b63b8525 (patch)
tree4f16e8d5bec9473928b2a03def299a17c775eb7c /tools
parent80873ec3c2e18c151ddf1c0d79461c48d367206f (diff)
downloadandroid-node-v8-f4510c4148b50b47ac22fdb5331ce726b63b8525.tar.gz
android-node-v8-f4510c4148b50b47ac22fdb5331ce726b63b8525.tar.bz2
android-node-v8-f4510c4148b50b47ac22fdb5331ce726b63b8525.zip
test, tools: suppress addon function cast warnings
Currently, there are a number of compiler warnings generated when building the addons on Linux, for example: make[1]: Entering directory '/node/test/addons/zlib-binding/build' CXX(target) Release/obj.target/binding/binding.o SOLINK_MODULE(target) Release/obj.target/binding.node COPY Release/binding.node make[1]: Leaving directory '/node/test/addons/zlib-binding/build' In file included from ../binding.cc:1: /node/src/node.h:515:51: warning: cast between incompatible function types from 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>)' to 'node::addon_context_register_func' {aka 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)'} [-Wcast-function-type] (node::addon_context_register_func) (regfunc), \ ^ /node/src/node.h:533:3: note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X' NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../binding.cc:58:1: note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE' NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize) ^~~~~~~~~~~~~~~~~~~~~~~~~ This commit adds the flag -Wno-cast-function-type to suppress these warnings. With this change the warnings are not displayed anymore and the output matches that of osx when running 'make -j8 test/addons/.buildstamp'. PR-URL: https://github.com/nodejs/node/pull/25663 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/doc/addon-verify.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/doc/addon-verify.js b/tools/doc/addon-verify.js
index ae6a08b2cc..2ff61c21f5 100644
--- a/tools/doc/addon-verify.js
+++ b/tools/doc/addon-verify.js
@@ -79,8 +79,8 @@ ${files[name].replace(
targets: [
{
target_name: 'addon',
- defines: [ 'V8_DEPRECATION_WARNINGS=1' ],
- sources: files.map(({ name }) => name)
+ sources: files.map(({ name }) => name),
+ includes: ['../common.gypi'],
}
]
})