diff options
author | Mark S. Everitt <mark.s.everitt@gmail.com> | 2019-02-06 22:24:50 +0000 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-02-09 16:34:25 +0100 |
commit | 1aa11e14440dc531a7208128b6416814f7b0964b (patch) | |
tree | 06ac2f7f58ee3996762bf8f4aca77343e2ecd43a /test | |
parent | f93df511558609fad38fe0ae34635c7c914ad2f8 (diff) | |
download | android-node-v8-1aa11e14440dc531a7208128b6416814f7b0964b.tar.gz android-node-v8-1aa11e14440dc531a7208128b6416814f7b0964b.tar.bz2 android-node-v8-1aa11e14440dc531a7208128b6416814f7b0964b.zip |
http2: makes response.writeHead return the response
Fixes: https://github.com/nodejs/node/issues/25935
PR-URL: https://github.com/nodejs/node/pull/25974
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-http2-compat-serverresponse-writehead-array.js | 3 | ||||
-rw-r--r-- | test/parallel/test-http2-compat-serverresponse-writehead.js | 6 |
2 files changed, 7 insertions, 2 deletions
diff --git a/test/parallel/test-http2-compat-serverresponse-writehead-array.js b/test/parallel/test-http2-compat-serverresponse-writehead-array.js index e024f8ab39..d856165d09 100644 --- a/test/parallel/test-http2-compat-serverresponse-writehead-array.js +++ b/test/parallel/test-http2-compat-serverresponse-writehead-array.js @@ -12,10 +12,11 @@ const server = h2.createServer(); server.listen(0, common.mustCall(() => { const port = server.address().port; server.once('request', common.mustCall((request, response) => { - response.writeHead(200, [ + const returnVal = response.writeHead(200, [ ['foo', 'bar'], ['ABC', 123] ]); + assert.strictEqual(returnVal, response); response.end(common.mustCall(() => { server.close(); })); })); diff --git a/test/parallel/test-http2-compat-serverresponse-writehead.js b/test/parallel/test-http2-compat-serverresponse-writehead.js index 5fd787e100..aabcf18ad9 100644 --- a/test/parallel/test-http2-compat-serverresponse-writehead.js +++ b/test/parallel/test-http2-compat-serverresponse-writehead.js @@ -13,7 +13,11 @@ server.listen(0, common.mustCall(function() { const port = server.address().port; server.once('request', common.mustCall(function(request, response) { response.setHeader('foo-bar', 'def456'); - response.writeHead(418, { 'foo-bar': 'abc123' }); // Override + + // Override + const returnVal = response.writeHead(418, { 'foo-bar': 'abc123' }); + + assert.strictEqual(returnVal, response); common.expectsError(() => { response.writeHead(300); }, { code: 'ERR_HTTP2_HEADERS_SENT' |