summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2019-02-07 10:17:16 -0500
committercjihrig <cjihrig@gmail.com>2019-02-09 12:08:05 -0500
commit00366e2acfd2ea878d463adc13aab9f668d3a62e (patch)
treed48e74f14820cc9340a3d9983b7742f45ee61be1 /test
parent3681ddd96744e46f12e11e3d5154ab4070e7290c (diff)
downloadandroid-node-v8-00366e2acfd2ea878d463adc13aab9f668d3a62e.tar.gz
android-node-v8-00366e2acfd2ea878d463adc13aab9f668d3a62e.tar.bz2
android-node-v8-00366e2acfd2ea878d463adc13aab9f668d3a62e.zip
test: remove extraneous report validation argument
The second argument passed to validate() and validateContent() is not used for anything. PR-URL: https://github.com/nodejs/node/pull/25986 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'test')
-rw-r--r--test/node-report/test-api-getreport.js5
-rw-r--r--test/node-report/test-api-nohooks.js4
-rw-r--r--test/node-report/test-api-pass-error.js5
-rw-r--r--test/node-report/test-api-uvhandles.js4
-rw-r--r--test/node-report/test-api.js4
-rw-r--r--test/node-report/test-exception.js4
-rw-r--r--test/node-report/test-fatal-error.js8
-rw-r--r--test/node-report/test-signal.js4
8 files changed, 8 insertions, 30 deletions
diff --git a/test/node-report/test-api-getreport.js b/test/node-report/test-api-getreport.js
index 178469412d..49e84d68a6 100644
--- a/test/node-report/test-api-getreport.js
+++ b/test/node-report/test-api-getreport.js
@@ -21,8 +21,5 @@ if (process.argv[2] === 'child') {
' experimental feature. This feature could change at any time'), std_msg);
const reportFiles = helper.findReports(child.pid, tmpdir.path);
assert.deepStrictEqual(reportFiles, [], report_msg);
- helper.validateContent(child.stdout, { pid: child.pid,
- commandline: process.execPath +
- ' ' + args.join(' ')
- });
+ helper.validateContent(child.stdout);
}
diff --git a/test/node-report/test-api-nohooks.js b/test/node-report/test-api-nohooks.js
index 8b497e0663..67d843c270 100644
--- a/test/node-report/test-api-nohooks.js
+++ b/test/node-report/test-api-nohooks.js
@@ -23,8 +23,6 @@ if (process.argv[2] === 'child') {
const reports = helper.findReports(child.pid, tmpdir.path);
assert.strictEqual(reports.length, 1, report_msg);
const report = reports[0];
- helper.validate(report, { pid: child.pid,
- commandline: child.spawnargs.join(' ')
- });
+ helper.validate(report);
}));
}
diff --git a/test/node-report/test-api-pass-error.js b/test/node-report/test-api-pass-error.js
index caac6c7e86..13e92570a7 100644
--- a/test/node-report/test-api-pass-error.js
+++ b/test/node-report/test-api-pass-error.js
@@ -25,9 +25,6 @@ if (process.argv[2] === 'child') {
const reports = helper.findReports(child.pid, tmpdir.path);
assert.strictEqual(reports.length, 1, report_msg);
const report = reports[0];
- helper.validate(report, { pid: child.pid,
- commandline: child.spawnargs.join(' '),
- expectedException: 'Testing error handling',
- });
+ helper.validate(report);
}));
}
diff --git a/test/node-report/test-api-uvhandles.js b/test/node-report/test-api-uvhandles.js
index 52f58b6e13..570fa42aa2 100644
--- a/test/node-report/test-api-uvhandles.js
+++ b/test/node-report/test-api-uvhandles.js
@@ -126,8 +126,6 @@ if (process.argv[2] === 'child') {
assert.deepStrictEqual(udp, 1, udp_msg);
// Common report tests.
- helper.validateContent(stdout, { pid: child.pid,
- commandline: child.spawnargs.join(' ')
- });
+ helper.validateContent(stdout);
}));
}
diff --git a/test/node-report/test-api.js b/test/node-report/test-api.js
index 9ffa66bb40..232fa1581f 100644
--- a/test/node-report/test-api.js
+++ b/test/node-report/test-api.js
@@ -22,8 +22,6 @@ if (process.argv[2] === 'child') {
const reports = helper.findReports(child.pid, tmpdir.path);
assert.strictEqual(reports.length, 1, report_msg);
const report = reports[0];
- helper.validate(report, { pid: child.pid,
- commandline: child.spawnargs.join(' ')
- });
+ helper.validate(report);
}));
}
diff --git a/test/node-report/test-exception.js b/test/node-report/test-exception.js
index 9e423ec29c..e2c801afb9 100644
--- a/test/node-report/test-exception.js
+++ b/test/node-report/test-exception.js
@@ -37,8 +37,6 @@ if (process.argv[2] === 'child') {
const reports = helper.findReports(child.pid, tmpdir.path);
assert.strictEqual(reports.length, 1, report_msg);
const report = reports[0];
- helper.validate(report, { pid: child.pid,
- commandline: child.spawnargs.join(' ')
- });
+ helper.validate(report);
}));
}
diff --git a/test/node-report/test-fatal-error.js b/test/node-report/test-fatal-error.js
index 3d830aa72f..b6cf792725 100644
--- a/test/node-report/test-fatal-error.js
+++ b/test/node-report/test-fatal-error.js
@@ -33,12 +33,6 @@ if (process.argv[2] === 'child') {
const reports = helper.findReports(child.pid, tmpdir.path);
assert.strictEqual(reports.length, 1);
const report = reports[0];
- const options = { pid: child.pid };
- // Node.js currently overwrites the command line on AIX
- // https://github.com/nodejs/node/issues/10607
- if (!(common.isAIX || common.isSunOS)) {
- options.commandline = child.spawnargs.join(' ');
- }
- helper.validate(report, options);
+ helper.validate(report);
}));
}
diff --git a/test/node-report/test-signal.js b/test/node-report/test-signal.js
index 7368bb51c3..129933b546 100644
--- a/test/node-report/test-signal.js
+++ b/test/node-report/test-signal.js
@@ -73,8 +73,6 @@ if (process.argv[2] === 'child') {
const reports = helper.findReports(child.pid, tmpdir.path);
assert.deepStrictEqual(reports.length, 1, report_msg);
const report = reports[0];
- helper.validate(report, { pid: child.pid,
- commandline: child.spawnargs.join(' ')
- });
+ helper.validate(report);
}));
}