diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-08 16:28:19 +0100 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-03-11 06:11:12 +0100 |
commit | 8d669bbeb1ed77e9cdc679f75d9e8529f5764087 (patch) | |
tree | 2b84c3a090de762ab014cb39f359cfcd68b40e9e /src/node_util.cc | |
parent | cc2c07ce0859f2df626bce912ba456439fdb33ec (diff) | |
download | android-node-v8-8d669bbeb1ed77e9cdc679f75d9e8529f5764087.tar.gz android-node-v8-8d669bbeb1ed77e9cdc679f75d9e8529f5764087.tar.bz2 android-node-v8-8d669bbeb1ed77e9cdc679f75d9e8529f5764087.zip |
process: refactor global.queueMicrotask()
- Lazy load `async_hooks` in the implementation
- Rename `process/next_tick.js` to `process/task_queues.js`
and move the implementation of `global.queueMicrotask()`
there since these methods are conceptually related to
each other.
- Move the bindings used by `global.queueMicrotask()` into
`node_task_queue.cc` instead of the generic `node_util.cc`
- Use `defineOperation` to define `global.queueMicrotask()`
PR-URL: https://github.com/nodejs/node/pull/26523
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_util.cc')
-rw-r--r-- | src/node_util.cc | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/node_util.cc b/src/node_util.cc index 6d20f636f0..b1cdc11a99 100644 --- a/src/node_util.cc +++ b/src/node_util.cc @@ -180,15 +180,6 @@ void ArrayBufferViewHasBuffer(const FunctionCallbackInfo<Value>& args) { args.GetReturnValue().Set(args[0].As<ArrayBufferView>()->HasBuffer()); } -void EnqueueMicrotask(const FunctionCallbackInfo<Value>& args) { - Environment* env = Environment::GetCurrent(args); - Isolate* isolate = env->isolate(); - - CHECK(args[0]->IsFunction()); - - isolate->EnqueueMicrotask(args[0].As<Function>()); -} - class WeakReference : public BaseObject { public: WeakReference(Environment* env, Local<Object> object, Local<Object> target) @@ -261,8 +252,6 @@ void Initialize(Local<Object> target, WatchdogHasPendingSigint); env->SetMethod(target, "arrayBufferViewHasBuffer", ArrayBufferViewHasBuffer); - env->SetMethod(target, "enqueueMicrotask", EnqueueMicrotask); - env->SetMethod(target, "triggerFatalException", FatalException); Local<Object> constants = Object::New(env->isolate()); NODE_DEFINE_CONSTANT(constants, ALL_PROPERTIES); NODE_DEFINE_CONSTANT(constants, ONLY_WRITABLE); |