diff options
| author | Timothy Gu <timothygu99@gmail.com> | 2018-06-22 01:25:12 -0400 |
|---|---|---|
| committer | Timothy Gu <timothygu99@gmail.com> | 2018-06-25 23:15:35 -0400 |
| commit | 65f617314d1ea2df8b9e16fb7e7078b5913c749c (patch) | |
| tree | 719a8cf6099c336eddf75af226ca1bfbd0b73965 /src/node_util.cc | |
| parent | cd8adfaf98613fb0ae4ba71018a236906f67f286 (diff) | |
| download | android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.tar.gz android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.tar.bz2 android-node-v8-65f617314d1ea2df8b9e16fb7e7078b5913c749c.zip | |
src: start annotating native code side effect
PR-URL: https://github.com/nodejs/node/pull/21458
Refs: https://github.com/nodejs/node/issues/20977
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_util.cc')
| -rw-r--r-- | src/node_util.cc | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/src/node_util.cc b/src/node_util.cc index 2db6858645..724bb3603c 100644 --- a/src/node_util.cc +++ b/src/node_util.cc @@ -212,18 +212,19 @@ void Initialize(Local<Object> target, V(kRejected); #undef V - env->SetMethod(target, "getHiddenValue", GetHiddenValue); + env->SetMethodNoSideEffect(target, "getHiddenValue", GetHiddenValue); env->SetMethod(target, "setHiddenValue", SetHiddenValue); - env->SetMethod(target, "getPromiseDetails", GetPromiseDetails); - env->SetMethod(target, "getProxyDetails", GetProxyDetails); - env->SetMethod(target, "safeToString", SafeToString); - env->SetMethod(target, "previewEntries", PreviewEntries); + env->SetMethodNoSideEffect(target, "getPromiseDetails", GetPromiseDetails); + env->SetMethodNoSideEffect(target, "getProxyDetails", GetProxyDetails); + env->SetMethodNoSideEffect(target, "safeToString", SafeToString); + env->SetMethodNoSideEffect(target, "previewEntries", PreviewEntries); env->SetMethod(target, "startSigintWatchdog", StartSigintWatchdog); env->SetMethod(target, "stopSigintWatchdog", StopSigintWatchdog); - env->SetMethod(target, "watchdogHasPendingSigint", WatchdogHasPendingSigint); + env->SetMethodNoSideEffect(target, "watchdogHasPendingSigint", + WatchdogHasPendingSigint); - env->SetMethod(target, "createPromise", CreatePromise); + env->SetMethodNoSideEffect(target, "createPromise", CreatePromise); env->SetMethod(target, "promiseResolve", PromiseResolve); env->SetMethod(target, "promiseReject", PromiseReject); |